[PR #2305] [MERGED] Fixed a bug with setting the statvfs value #2462

New issue

Closed

opened 2026-03-04 02:05:40 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:05:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2305
Author: @ggtakec
Created: 9/4/2023
Status: ✅ Merged
Merged: 9/5/2023
Merged by: @gaul

Base: master ← Head: fix_statvfs

📝 Commits (1)

d640711 Fixed a bug with setting the statvfs value

📊 Changes

2 files changed (+127 additions, -68 deletions)

View changed files

📝 src/s3fs.cpp (+103 -68)
📝 test/integration-test-main.sh (+24 -0)

📄 Description

Relevant Issue (if applicable)

n/a

Details

I noticed that the results of the df command are strange.
In macos, all block sizes and free block sizes were zero.
Also, the values seemed strange on Linux(using a 64-bit block size).
Revised the statvfs setting function(s3fs_statvfs) and fixed it so that if the block_size option is not specified, the maximum size is used.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2305 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 9/4/2023 **Status:** ✅ Merged **Merged:** 9/5/2023 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `fix_statvfs` --- ### 📝 Commits (1) - [`d640711`](https://github.com/s3fs-fuse/s3fs-fuse/commit/d640711c4f5a961be2b061e9120f7ab09504e133) Fixed a bug with setting the statvfs value ### 📊 Changes **2 files changed** (+127 additions, -68 deletions) <details> <summary>View changed files</summary> 📝 `src/s3fs.cpp` (+103 -68) 📝 `test/integration-test-main.sh` (+24 -0) </details> ### 📄 Description ### Relevant Issue (if applicable) n/a ### Details I noticed that the results of the `df` command are strange. In macos, all block sizes and free block sizes were zero. Also, the values seemed strange on Linux(using a 64-bit block size). Revised the `statvfs` setting function(`s3fs_statvfs`) and fixed it so that if the `block_size` option is not specified, the maximum size is used. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>