[PR #2295] [MERGED] s3fs: print unmounting hint when the mount point is stale #2453

Closed
opened 2026-03-04 02:05:37 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2295
Author: @adamqqqplay
Created: 8/28/2023
Status: Merged
Merged: 9/3/2023
Merged by: @ggtakec

Base: masterHead: umount-stale-mountpoint


📝 Commits (1)

  • 4a20b3e s3fs: print unmounting hint when the mount point is stale

📊 Changes

1 file changed (+37 additions, -1 deletions)

View changed files

📝 src/s3fs.cpp (+37 -1)

📄 Description

Relevant Issue (if applicable)

Details

When situations such as out of memory (OOM) occur, s3fs may receive a SIGKILL signal and exit before cleaning up the mountpoint. At this time, a stale mount point will be left, causing an error to be reported the next time s3fs is mounted: Transport endpoint is not connected.

This patch adds a feature: before s3fs mount, check if the stat information of the mountpoint returns ENOTCONN error, if so, it will execute the umount operation to unmount the stale mountpoint.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2295 **Author:** [@adamqqqplay](https://github.com/adamqqqplay) **Created:** 8/28/2023 **Status:** ✅ Merged **Merged:** 9/3/2023 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `umount-stale-mountpoint` --- ### 📝 Commits (1) - [`4a20b3e`](https://github.com/s3fs-fuse/s3fs-fuse/commit/4a20b3ea5226eadba7927c6ec8473251b08a1d65) s3fs: print unmounting hint when the mount point is stale ### 📊 Changes **1 file changed** (+37 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/s3fs.cpp` (+37 -1) </details> ### 📄 Description ### Relevant Issue (if applicable) <!-- If there are Issues related to this PullRequest, please list it. --> ### Details When situations such as out of memory (OOM) occur, s3fs may receive a SIGKILL signal and exit before cleaning up the mountpoint. At this time, a stale mount point will be left, causing an error to be reported the next time s3fs is mounted: Transport endpoint is not connected. This patch adds a feature: before s3fs mount, check if the stat information of the mountpoint returns ENOTCONN error, if so, it will execute the umount operation to unmount the stale mountpoint. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-04 02:05:37 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/s3fs-fuse#2453
No description provided.