[PR #2273] [MERGED] Remove unneeded explicit `std::string` constructors #2435

New issue

Closed

opened 2026-03-04 02:05:31 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:05:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2273
Author: @gaul
Created: 8/16/2023
Status: ✅ Merged
Merged: 8/17/2023
Merged by: @ggtakec

Base: master ← Head: string/constructor

📝 Commits (1)

c775f34 Remove unneeded explicit std::string constructors

📊 Changes

11 files changed (+56 additions, -54 deletions)

View changed files

📝 src/cache.cpp (+2 -2)
📝 src/common_auth.cpp (+3 -2)
📝 src/curl.cpp (+10 -9)
📝 src/curl_util.cpp (+5 -5)
📝 src/fdcache.cpp (+3 -3)
📝 src/fdcache_entity.cpp (+1 -1)
📝 src/s3fs.cpp (+16 -16)
📝 src/s3fs_cred.cpp (+2 -2)
📝 src/s3fs_util.cpp (+4 -4)
📝 src/s3fs_xml.cpp (+2 -2)
📝 src/s3objlist.cpp (+8 -8)

📄 Description

std::string(const char*) implicitly constructs these. The remaining call sites requires string literals from C++14.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2273 **Author:** [@gaul](https://github.com/gaul) **Created:** 8/16/2023 **Status:** ✅ Merged **Merged:** 8/17/2023 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `string/constructor` --- ### 📝 Commits (1) - [`c775f34`](https://github.com/s3fs-fuse/s3fs-fuse/commit/c775f3420dc8973e8c42dfdf0ec83822194c9ea1) Remove unneeded explicit std::string constructors ### 📊 Changes **11 files changed** (+56 additions, -54 deletions) <details> <summary>View changed files</summary> 📝 `src/cache.cpp` (+2 -2) 📝 `src/common_auth.cpp` (+3 -2) 📝 `src/curl.cpp` (+10 -9) 📝 `src/curl_util.cpp` (+5 -5) 📝 `src/fdcache.cpp` (+3 -3) 📝 `src/fdcache_entity.cpp` (+1 -1) 📝 `src/s3fs.cpp` (+16 -16) 📝 `src/s3fs_cred.cpp` (+2 -2) 📝 `src/s3fs_util.cpp` (+4 -4) 📝 `src/s3fs_xml.cpp` (+2 -2) 📝 `src/s3objlist.cpp` (+8 -8) </details> ### 📄 Description `std::string(const char*)` implicitly constructs these. The remaining call sites requires string literals from C++14. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>