[PR #2206] [MERGED] Check FdEntity::Open() status correctly #2389

New issue

Closed

opened 2026-03-04 02:05:17 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:05:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2206
Author: @eryugey
Created: 7/4/2023
Status: ✅ Merged
Merged: 7/4/2023
Merged by: @gaul

Base: master ← Head: open

📝 Commits (1)

dde1923 Check FdEntity::Open() status correctly

📊 Changes

1 file changed (+3 additions, -2 deletions)

View changed files

📝 src/fdcache.cpp (+3 -2)

📄 Description

FdEntity::Open() returns -errno on error, but FdManager::Open() only checks if its ret is -1. This may lead to use '-errno' as pseudo fd in next read or write, which would fail due to '-errno' is not in fent map.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2206 **Author:** [@eryugey](https://github.com/eryugey) **Created:** 7/4/2023 **Status:** ✅ Merged **Merged:** 7/4/2023 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `open` --- ### 📝 Commits (1) - [`dde1923`](https://github.com/s3fs-fuse/s3fs-fuse/commit/dde1923e46d54845ce6ea78fd3c9c448b73d47bc) Check FdEntity::Open() status correctly ### 📊 Changes **1 file changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/fdcache.cpp` (+3 -2) </details> ### 📄 Description FdEntity::Open() returns -errno on error, but FdManager::Open() only checks if its ret is -1. This may lead to use '-errno' as pseudo fd in next read or write, which would fail due to '-errno' is not in fent map. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>