[PR #2204] [MERGED] fix streamuplod not working #2387

New issue

Closed

opened 2026-03-04 02:05:17 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:05:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2204
Author: @VVoidV
Created: 7/1/2023
Status: ✅ Merged
Merged: 7/2/2023
Merged by: @ggtakec

Base: master ← Head: fix-streamupload

📝 Commits (1)

fba7d3e fix streamuplod not working

📊 Changes

1 file changed (+7 additions, -12 deletions)

View changed files

📝 src/s3fs.cpp (+7 -12)

📄 Description

Relevant Issue (if applicable)

#2203 #2188

Details

fuse_main will do fork to daemonize. if ThreadPool is created before this, worker thread will not be placed in child process.

Move ThreadPool Init to s3fs_init and destory to s3fs_destory.

#2188 may be also related to this. When umount s3fs, ThreadPool::Destroy() will dereference some stale handler.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2204 **Author:** [@VVoidV](https://github.com/VVoidV) **Created:** 7/1/2023 **Status:** ✅ Merged **Merged:** 7/2/2023 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `fix-streamupload` --- ### 📝 Commits (1) - [`fba7d3e`](https://github.com/s3fs-fuse/s3fs-fuse/commit/fba7d3e9e637f65c2b0ba07eee15b674f371a2fb) fix streamuplod not working ### 📊 Changes **1 file changed** (+7 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `src/s3fs.cpp` (+7 -12) </details> ### 📄 Description  ### Relevant Issue (if applicable)  #2203 #2188 ### Details  fuse_main will do fork to daemonize. if ThreadPool is created before this, worker thread will not be placed in child process. Move ThreadPool Init to s3fs_init and destory to s3fs_destory. #2188 may be also related to this. When umount s3fs, ThreadPool::Destroy() will dereference some stale handler. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>