[PR #2201] [MERGED] Fix extended attribute support when using FUSE-T #2386

New issue

Closed

opened 2026-03-04 02:05:17 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:05:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2201
Author: @macos-fuse-t
Created: 6/26/2023
Status: ✅ Merged
Merged: 6/26/2023
Merged by: @ggtakec

Base: master ← Head: master

📝 Commits (3)

7c4fe74 Add support for FUSE-T on macos
9da7f0f Ignore value pointer when size is zero on setattrx
e45c212 Merge branch 's3fs-fuse:master' into master

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/s3fs.cpp (+1 -1)

📄 Description

This PR fixes extended attribute support when using FUSE-T.

Relevant Issue (if applicable)

Details

When libfuse receives an attribute size of 0, the pointer is not defined and should not be assumed to be NULL.
Relevant libfuse code:
struct fuse_setxattr_in *arg = (struct fuse_setxattr_in *) inarg;
char *name = PARAM(arg);
char *value = name + strlen(name) + 1;
...
req->f->op.setxattr(req, nodeid, name, value, arg->size, arg->flags, arg->position);

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2201 **Author:** [@macos-fuse-t](https://github.com/macos-fuse-t) **Created:** 6/26/2023 **Status:** ✅ Merged **Merged:** 6/26/2023 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`7c4fe74`](https://github.com/s3fs-fuse/s3fs-fuse/commit/7c4fe74cc26e7b584b022613375090a39c22e217) Add support for FUSE-T on macos - [`9da7f0f`](https://github.com/s3fs-fuse/s3fs-fuse/commit/9da7f0f79376020307a6c42c4dda025dee246fae) Ignore value pointer when size is zero on setattrx - [`e45c212`](https://github.com/s3fs-fuse/s3fs-fuse/commit/e45c212fccd0622082c169d59d4a1ad29de5c1a6) Merge branch 's3fs-fuse:master' into master ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/s3fs.cpp` (+1 -1) </details> ### 📄 Description  This PR fixes extended attribute support when using FUSE-T. ### Relevant Issue (if applicable)  ### Details  When libfuse receives an attribute size of 0, the pointer is not defined and should not be assumed to be NULL. Relevant libfuse code: struct fuse_setxattr_in *arg = (struct fuse_setxattr_in *) inarg; char *name = PARAM(arg); char *value = name + strlen(name) + 1; ... req->f->op.setxattr(req, nodeid, name, value, arg->size, arg->flags, arg->position); --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>