[PR #2197] [MERGED] Supported cppcheck 2.10(and changed std from c++03 to c++11 for RHEL7) #2382

New issue

Closed

opened 2026-03-04 02:05:15 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:05:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2197
Author: @ggtakec
Created: 6/25/2023
Status: ✅ Merged
Merged: 7/24/2023
Merged by: @gaul

Base: master ← Head: fix_cppcheck210

📝 Commits (1)

f4efa85 Supported cppcheck 2.10(and changed std from c++03 to c++11 for RHEL7)

📊 Changes

6 files changed (+20 additions, -13 deletions)

View changed files

📝 .github/workflows/ci.yml (+3 -3)
📝 Makefile.am (+2 -2)
📝 configure.ac (+1 -1)
📝 src/curl.cpp (+1 -1)
📝 src/fdcache.cpp (+1 -1)
📝 src/fdcache_page.cpp (+12 -5)

📄 Description

Relevant Issue (if applicable)

#2163
#2162
#2179

Details

Fixed errors detected by cppcheck v2.10 (SUSE leap:15).

This reverts the setting that was temporarily disabled(v2.10 and useStlAlgorithm) in #2163.
With this fix, cppcheck checks can be done on all OSs.

Support for CentOS7(which was discussed in #2195) is resolved by adding the -std=c++11 CXXFLAGS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2197 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 6/25/2023 **Status:** ✅ Merged **Merged:** 7/24/2023 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `fix_cppcheck210` --- ### 📝 Commits (1) - [`f4efa85`](https://github.com/s3fs-fuse/s3fs-fuse/commit/f4efa855b8f96078188f7f007bf228d768163149) Supported cppcheck 2.10(and changed std from c++03 to c++11 for RHEL7) ### 📊 Changes **6 files changed** (+20 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+3 -3) 📝 `Makefile.am` (+2 -2) 📝 `configure.ac` (+1 -1) 📝 `src/curl.cpp` (+1 -1) 📝 `src/fdcache.cpp` (+1 -1) 📝 `src/fdcache_page.cpp` (+12 -5) </details> ### 📄 Description ### Relevant Issue (if applicable) #2163 #2162 #2179 ### Details Fixed errors detected by `cppcheck v2.10 (SUSE leap:15)`. This reverts the setting that was temporarily disabled(`v2.10` and `useStlAlgorithm`) in #2163. With this fix, cppcheck checks can be done on all OSs. Support for `CentOS7`(which was discussed in #2195) is resolved by adding the `-std=c++11` CXXFLAGS. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>