[PR #2195] [MERGED] Replace some raw pointers with std::unique_ptr #2380

Closed
opened 2026-03-04 02:05:14 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2195
Author: @gaul
Created: 6/24/2023
Status: Merged
Merged: 7/27/2023
Merged by: @ggtakec

Base: masterHead: c++/unique_ptr


📝 Commits (1)

  • ff3368c Replace some raw pointers with std::unique_ptr

📊 Changes

15 files changed (+109 additions, -166 deletions)

View changed files

📝 src/addhead.cpp (+10 -24)
📝 src/addhead.h (+9 -2)
📝 src/curl.cpp (+16 -31)
📝 src/curl.h (+2 -1)
📝 src/curl_multi.cpp (+19 -23)
📝 src/curl_multi.h (+4 -2)
📝 src/fdcache_entity.cpp (+13 -19)
📝 src/fdcache_fdinfo.cpp (+4 -8)
📝 src/fdcache_fdinfo.h (+3 -1)
📝 src/fdcache_page.cpp (+6 -13)
📝 src/s3fs.cpp (+3 -4)
📝 src/s3fs_logger.cpp (+9 -12)
📝 src/s3fs_util.cpp (+7 -17)
📝 src/string_util.h (+1 -0)
📝 src/types.h (+3 -9)

📄 Description

This simplifies code paths and makes memory leaks less likely. It also makes memory ownership more explicit by requiring std::move. This commit requires C++11. References #2179.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2195 **Author:** [@gaul](https://github.com/gaul) **Created:** 6/24/2023 **Status:** ✅ Merged **Merged:** 7/27/2023 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `c++/unique_ptr` --- ### 📝 Commits (1) - [`ff3368c`](https://github.com/s3fs-fuse/s3fs-fuse/commit/ff3368c01301949376a7816611c258a44cd42929) Replace some raw pointers with std::unique_ptr ### 📊 Changes **15 files changed** (+109 additions, -166 deletions) <details> <summary>View changed files</summary> 📝 `src/addhead.cpp` (+10 -24) 📝 `src/addhead.h` (+9 -2) 📝 `src/curl.cpp` (+16 -31) 📝 `src/curl.h` (+2 -1) 📝 `src/curl_multi.cpp` (+19 -23) 📝 `src/curl_multi.h` (+4 -2) 📝 `src/fdcache_entity.cpp` (+13 -19) 📝 `src/fdcache_fdinfo.cpp` (+4 -8) 📝 `src/fdcache_fdinfo.h` (+3 -1) 📝 `src/fdcache_page.cpp` (+6 -13) 📝 `src/s3fs.cpp` (+3 -4) 📝 `src/s3fs_logger.cpp` (+9 -12) 📝 `src/s3fs_util.cpp` (+7 -17) 📝 `src/string_util.h` (+1 -0) 📝 `src/types.h` (+3 -9) </details> ### 📄 Description This simplifies code paths and makes memory leaks less likely. It also makes memory ownership more explicit by requiring `std::move`. This commit requires C++11. References #2179. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-04 02:05:14 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/s3fs-fuse#2380
No description provided.