[PR #2184] [MERGED] Fixed test setting for macOS #2376

New issue

Closed

opened 2026-03-04 02:05:13 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:05:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2184
Author: @ggtakec
Created: 6/7/2023
Status: ✅ Merged
Merged: 6/8/2023
Merged by: @gaul

Base: master ← Head: fix_macos_test

📝 Commits (1)

5d7ee96 Fixed test setting for macOS

📊 Changes

1 file changed (+12 additions, -1 deletions)

View changed files

📝 test/integration-test-common.sh (+12 -1)

📄 Description

Relevant Issue (if applicable)

n/a

Details

For testing on macOS, we need to change two test settings:

How to pass parameters to `keytool` when generating `keystore.jks` used by s3proxy

echo -e should be changed to printf considering the case where macOS echo is different
The parameter yes is not accepted unless it is y.

A case for failure to verify SSL certificate

The exact reason is still unknown, but since verifying of the SSL certificate resulted in an error, we will prepare a means to bypass this. (Specify NO_CHECK_CERT=1 when executing make check)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2184 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 6/7/2023 **Status:** ✅ Merged **Merged:** 6/8/2023 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `fix_macos_test` --- ### 📝 Commits (1) - [`5d7ee96`](https://github.com/s3fs-fuse/s3fs-fuse/commit/5d7ee96d3cdc4249c2e1f9fc71755b7e03bd0b56) Fixed test setting for macOS ### 📊 Changes **1 file changed** (+12 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `test/integration-test-common.sh` (+12 -1) </details> ### 📄 Description ### Relevant Issue (if applicable) n/a ### Details For testing on macOS, we need to change two test settings: ##### How to pass parameters to `keytool` when generating `keystore.jks` used by s3proxy `echo -e` should be changed to printf considering the case where macOS `echo` is different The parameter `yes` is not accepted unless it is `y`. ##### A case for failure to verify SSL certificate The exact reason is still unknown, but since verifying of the SSL certificate resulted in an error, we will prepare a means to bypass this. (Specify `NO_CHECK_CERT=1` when executing `make check`) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>