starred/s3fs-fuse

Fork 0

mirror of https://github.com/s3fs-fuse/s3fs-fuse.git synced 2026-04-25 13:26:00 +03:00

[GH-ISSUE #437] Why exit the process when encounter unknown curl errors? #237

New issue

Closed

opened 2026-03-04 01:43:33 +03:00 by kerem · 5 comments

kerem commented

2026-03-04 01:43:33 +03:00

Owner

Originally created by @rockuw on GitHub (Jun 24, 2016).
Original GitHub issue: https://github.com/s3fs-fuse/s3fs-fuse/issues/437

//curl.cpp:2047
      // Unknown CURL return code
      default:
        S3FS_PRN_CRIT("###curlCode: %d  msg: %s", curlCode, curl_easy_strerror(curlCode));
        exit(EXIT_FAILURE);
        break;

Even if we cannot handle the curl error, it affects only one request which may succeed after user retry. So is there any special considerations here?

@ggtakec

Originally created by @rockuw on GitHub (Jun 24, 2016). Original GitHub issue: https://github.com/s3fs-fuse/s3fs-fuse/issues/437 ``` cpp //curl.cpp:2047 // Unknown CURL return code default: S3FS_PRN_CRIT("###curlCode: %d msg: %s", curlCode, curl_easy_strerror(curlCode)); exit(EXIT_FAILURE); break; ``` Even if we cannot handle the curl error, it affects only one request which may succeed after user retry. So is there any special considerations here? @ggtakec

kerem closed this issue

2026-03-04 01:43:33 +03:00

kerem commented

2026-03-04 01:43:34 +03:00

Author

Owner

@ggtakec commented on GitHub (Jun 26, 2016):

@rockuw
Special consideration have not been made about this older than 1.60.
This means s3fs is determined it can not recover and exits assap because s3fs can not be handled this error. (but s3fs should run post-processing.)

Regards,

@ggtakec commented on GitHub (Jun 26, 2016): @rockuw Special consideration have not been made about this older than 1.60. This means s3fs is determined it can not recover and exits assap because s3fs can not be handled this error. (but s3fs should run post-processing.) Regards,

kerem commented

2026-03-04 01:43:34 +03:00

Author

Owner

@rockuw commented on GitHub (Jun 27, 2016):

s3fs could handle it in this way: just return EIO when an unknown curl error is encountered. What do you think?

@ggtakec

@rockuw commented on GitHub (Jun 27, 2016): s3fs could handle it in this way: just return EIO when an unknown curl error is encountered. What do you think? @ggtakec

kerem commented

2026-03-04 01:43:35 +03:00

Author

Owner

@ggtakec commented on GitHub (Jun 27, 2016):

@rockuw That you said is correct.
I think that I also do not see the reason to exit in S3fsCurl class.
Correctly, this method returns an error of such EIO, the error should have been treated with the caller.

For now, the calling exit() in this function has been changed to returning EIO after I tested codes.
And I merged codes by #440.

Please check it and try it.

Regards,

@ggtakec commented on GitHub (Jun 27, 2016): @rockuw That you said is correct. I think that I also do not see the reason to exit in S3fsCurl class. Correctly, this method returns an error of such EIO, the error should have been treated with the caller. For now, the calling exit() in this function has been changed to returning EIO after I tested codes. And I merged codes by #440. Please check it and try it. Regards,

kerem commented

2026-03-04 01:43:35 +03:00

Author

Owner

@gaul commented on GitHub (Feb 2, 2019):

@rockuw did this change resolve your symptoms? If so please close this issue.

@gaul commented on GitHub (Feb 2, 2019): @rockuw did this change resolve your symptoms? If so please close this issue.

kerem commented

2026-03-04 01:43:35 +03:00

Author

Owner

@gaul commented on GitHub (Apr 9, 2019):

Closing due to inactivity. Please reopen if symptoms persist.

@gaul commented on GitHub (Apr 9, 2019): Closing due to inactivity. Please reopen if symptoms persist.

kerem referenced this issue

2026-03-04 01:53:50 +03:00

[PR #237] [MERGED] Refactor tests into individual functions #1414