[PR #2169] [CLOSED] Added need_datasync option #2369

New issue

Closed

opened 2026-03-04 02:05:10 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:05:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2169
Author: @ggtakec
Created: 5/27/2023
Status: ❌ Closed

Base: master ← Head: add_sync_opt

📝 Commits (1)

ec75fad Added need_datasync option

📊 Changes

5 files changed (+25 additions, -2 deletions)

View changed files

📝 doc/man/s3fs.1.in (+4 -0)
📝 src/curl.cpp (+10 -2)
📝 src/curl.h (+2 -0)
📝 src/s3fs.cpp (+4 -0)
📝 src/s3fs_help.cpp (+5 -0)

📄 Description

Relevant Issue (if applicable)

#2157

Details

By merging #2157, it is now possible to sync data when downloading.
However, I want to limit this call to fdatasync with this need_datasync option(which is disabled by default).
But we will check in the long term if this option will be no longer necessary.

@gaul
This PR ties in with #2157 and will be merged soon.
Please let me know if you have any problems.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2169 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 5/27/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `add_sync_opt` --- ### 📝 Commits (1) - [`ec75fad`](https://github.com/s3fs-fuse/s3fs-fuse/commit/ec75fadb719dd4254b0e76813389949ad237e73d) Added need_datasync option ### 📊 Changes **5 files changed** (+25 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `doc/man/s3fs.1.in` (+4 -0) 📝 `src/curl.cpp` (+10 -2) 📝 `src/curl.h` (+2 -0) 📝 `src/s3fs.cpp` (+4 -0) 📝 `src/s3fs_help.cpp` (+5 -0) </details> ### 📄 Description ### Relevant Issue (if applicable) #2157 ### Details By merging #2157, it is now possible to sync data when downloading. However, I want to limit this call to `fdatasync` with this `need_datasync` option(which is disabled by default). But we will check in the long term if this option will be no longer necessary. @gaul This PR ties in with #2157 and will be merged soon. Please let me know if you have any problems. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>