[PR #2165] [CLOSED] Add AWS SSO authentication and option aws_home_dir (s3fs-fuse#1931) #2368

New issue

Closed

opened 2026-03-04 02:05:10 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:05:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2165
Author: @darioackermann
Created: 5/15/2023
Status: ❌ Closed

Base: master ← Head: dac/merge-sso

📝 Commits (10+)

2211c37 Add AWS SSO authentication and option aws_home_dir (s3fs-fuse#1931)
9505df1 Use awscliv2 via pip3 and add nlohmann json package (s3fs-fuse#1931)
c508792 Fiw awscliv2 installation (s3fs-fuse#1931)
2954da3 Fix shellcheck part removing pip env variables (s3fs-fuse#1931)
ec32fa0 Add comment for ssl keystore to test (s3fs-fuse#1931)
85cb87c Fix workflows (s3fs-fuse#1931)
8759cfe Fix ubuntu 18 and rockylinux (s3fs-fuse#1931)
52e479f Fix debian:stretch ci (s3fs-fuse#1931)
9b715a3 Fix CXXFLAGS for mac ci. from c++03 to c++11 (s3fs-fuse#1931)
51ef6b0 Fix profile parsing for sso (manage 'profile %profile%') (s3fs-fuse#1931)

📊 Changes

8 files changed (+221 additions, -25 deletions)

View changed files

📝 .github/workflows/ci.yml (+2 -2)
📝 .github/workflows/linux-ci-helper.sh (+21 -21)
📝 COMPILATION.md (+1 -0)
📝 doc/man/s3fs.1.in (+6 -0)
📝 src/s3fs_cred.cpp (+178 -2)
📝 src/s3fs_cred.h (+7 -0)
📝 src/s3fs_help.cpp (+5 -0)
📝 test/integration-test-common.sh (+1 -0)

📄 Description

Relevant Issue (if applicable)

#1931
already open MR: #1932

Details

Adds credentials grabbing from SSO

This is not very different from #1932
I have made the integration tests work (except for centos and rockylinux, for which the header is not available as package - what should we do there?) and adjusted stuff such that cppcheck doesn't complain, and resolved merge conflicts.

We could default that SSO support is not enabled automatically for centos/rockylinux builds. (and add a flag for enabling it).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2165 **Author:** [@darioackermann](https://github.com/darioackermann) **Created:** 5/15/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `dac/merge-sso` --- ### 📝 Commits (10+) - [`2211c37`](https://github.com/s3fs-fuse/s3fs-fuse/commit/2211c37f70c3a9e621b704e3bbc1ef7c7f3cfe3f) Add AWS SSO authentication and option aws_home_dir (s3fs-fuse#1931) - [`9505df1`](https://github.com/s3fs-fuse/s3fs-fuse/commit/9505df1bd6e09794a1694facb8d3b5a7692c2a17) Use awscliv2 via pip3 and add nlohmann json package (s3fs-fuse#1931) - [`c508792`](https://github.com/s3fs-fuse/s3fs-fuse/commit/c50879284c94fbef33f77241bd062fd46d3b5e80) Fiw awscliv2 installation (s3fs-fuse#1931) - [`2954da3`](https://github.com/s3fs-fuse/s3fs-fuse/commit/2954da31130296f6510ae9d266e22bf8ed49130f) Fix shellcheck part removing pip env variables (s3fs-fuse#1931) - [`ec32fa0`](https://github.com/s3fs-fuse/s3fs-fuse/commit/ec32fa058f7d238638b90bd4e7fa007fcb5f8e9c) Add comment for ssl keystore to test (s3fs-fuse#1931) - [`85cb87c`](https://github.com/s3fs-fuse/s3fs-fuse/commit/85cb87c2023b754dab92ea95afc00cc71ae5f2ed) Fix workflows (s3fs-fuse#1931) - [`8759cfe`](https://github.com/s3fs-fuse/s3fs-fuse/commit/8759cfe43e6437fa72934f43b4191f15b29149d0) Fix ubuntu 18 and rockylinux (s3fs-fuse#1931) - [`52e479f`](https://github.com/s3fs-fuse/s3fs-fuse/commit/52e479fed9d0a5bf296025a29fe13d5e83708485) Fix debian:stretch ci (s3fs-fuse#1931) - [`9b715a3`](https://github.com/s3fs-fuse/s3fs-fuse/commit/9b715a39f21af762870adfdeb3b91866746d717a) Fix CXXFLAGS for mac ci. from c++03 to c++11 (s3fs-fuse#1931) - [`51ef6b0`](https://github.com/s3fs-fuse/s3fs-fuse/commit/51ef6b0dbf9f4e1a086720c318975d272dc8446d) Fix profile parsing for sso (manage 'profile %profile%') (s3fs-fuse#1931) ### 📊 Changes **8 files changed** (+221 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+2 -2) 📝 `.github/workflows/linux-ci-helper.sh` (+21 -21) 📝 `COMPILATION.md` (+1 -0) 📝 `doc/man/s3fs.1.in` (+6 -0) 📝 `src/s3fs_cred.cpp` (+178 -2) 📝 `src/s3fs_cred.h` (+7 -0) 📝 `src/s3fs_help.cpp` (+5 -0) 📝 `test/integration-test-common.sh` (+1 -0) </details> ### 📄 Description ### Relevant Issue (if applicable) #1931 already open MR: #1932 ### Details * Adds credentials grabbing from SSO This is not very different from #1932 I have made the integration tests work (except for centos and rockylinux, for which the header is not available as package - what should we do there?) and adjusted stuff such that cppcheck doesn't complain, and resolved merge conflicts. We could default that SSO support is not enabled automatically for centos/rockylinux builds. (and add a flag for enabling it). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>