[PR #2130] [CLOSED] Fix an issue that cache space will not be freed #2348

New issue

Closed

opened 2026-03-04 02:05:04 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:05:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2130
Author: @huntersman
Created: 3/15/2023
Status: ❌ Closed

Base: master ← Head: fix-space-not-free

📝 Commits (1)

d6c5707 Update s3fs.cpp

📊 Changes

1 file changed (+13 additions, -6 deletions)

View changed files

📝 src/s3fs.cpp (+13 -6)

📄 Description

Relevant Issue (if applicable)

#2128

Details

I think cache space will not be freed is because s3fs_unlink already delete the cache file, but .fuse_hidden file is generated which is also in the cache space. So I use a set to record file which is downloading, and only remove cache file when file is not in set.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2130 **Author:** [@huntersman](https://github.com/huntersman) **Created:** 3/15/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix-space-not-free` --- ### 📝 Commits (1) - [`d6c5707`](https://github.com/s3fs-fuse/s3fs-fuse/commit/d6c570703732b2e9eeebb6f44076adc97bdb0ef7) Update s3fs.cpp ### 📊 Changes **1 file changed** (+13 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/s3fs.cpp` (+13 -6) </details> ### 📄 Description  ### Relevant Issue (if applicable)  #2128 ### Details  I think cache space will not be freed is because `s3fs_unlink` already delete the cache file, but `.fuse_hidden` file is generated which is also in the cache space. So I use a set to record file which is downloading, and only remove cache file when file is not in set. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>