[PR #2114] [MERGED] Fixed to fail when the mount point directory is not existed #2340

New issue

Closed

opened 2026-03-04 02:05:01 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:05:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2114
Author: @ggtakec
Created: 2/19/2023
Status: ✅ Merged
Merged: 3/5/2023
Merged by: @ggtakec

Base: master ← Head: fix_check_bucket

📝 Commits (1)

fddae55 Fixed to fail when the mount point directory is not existed

📊 Changes

1 file changed (+13 additions, -4 deletions)

View changed files

📝 src/s3fs.cpp (+13 -4)

📄 Description

Relevant Issue (if applicable)

https://github.com/s3fs-fuse/s3fs-fuse/issues/1460#issuecomment-1425279454 #1728 #2087

Details

We fixed some mount point checking by #1728 and #2087.
But when specifying <bucket>/<directory>(/...) as the mount point, and if that mount point directory does not exist, it is not an error.
This bug was reported by @ValentinNikin.

If this error does not occur, a directory that does not exist will be mounted as a mount point, and directories/files can be manipulated under that directory.

Therefore, this case has been corrected to be an error.
(This fix is same behavior as v1.91 and below)

Note

Even if the directory object as mount point does not exist, an error will not occur if an object containing that path exists.
For example, if <bucket>/<directory>/<file> is created with a CLI tool, <bucket>/<directory>/<file> exists, but <bucket>/<directory> does not exist.
And in the case of specifying <bucket>/<directory> as the mount point.

This fix will be merged soon.
If the review is not completed by the time of the merge, please let me know later.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2114 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 2/19/2023 **Status:** ✅ Merged **Merged:** 3/5/2023 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `fix_check_bucket` --- ### 📝 Commits (1) - [`fddae55`](https://github.com/s3fs-fuse/s3fs-fuse/commit/fddae55196fc0fdd03f0aee4e380fee23b846db1) Fixed to fail when the mount point directory is not existed ### 📊 Changes **1 file changed** (+13 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/s3fs.cpp` (+13 -4) </details> ### 📄 Description ### Relevant Issue (if applicable) https://github.com/s3fs-fuse/s3fs-fuse/issues/1460#issuecomment-1425279454 #1728 #2087 ### Details We fixed some mount point checking by #1728 and #2087. But when specifying `<bucket>/<directory>(/...)` as the mount point, and if that mount point directory does not exist, it is not an error. This bug was reported by @ValentinNikin. If this error does not occur, a directory that does not exist will be mounted as a mount point, and directories/files can be manipulated under that directory. Therefore, this case has been corrected to be an error. (This fix is same behavior as v1.91 and below) #### Note _Even if the directory object as mount point does not exist, an error will not occur if an object containing that path exists._ _For example, if `<bucket>/<directory>/<file>` is created with a CLI tool, `<bucket>/<directory>/<file>` exists, but `<bucket>/<directory>` does not exist._ _And in the case of specifying `<bucket>/<directory>` as the mount point._ This fix will be merged soon. If the review is not completed by the time of the merge, please let me know later. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>