[PR #2097] [MERGED] multipart upload id is converted by url encode #2335

New issue

Closed

opened 2026-03-04 02:04:59 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:04:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2097
Author: @ggtakec
Created: 1/22/2023
Status: ✅ Merged
Merged: 2/18/2023
Merged by: @ggtakec

Base: master ← Head: encode_uploadid

📝 Commits (1)

bd8838f multipart upload id is converted by url encode

📊 Changes

6 files changed (+77 additions, -63 deletions)

View changed files

📝 src/curl.cpp (+26 -7)
📝 src/curl_util.cpp (+1 -1)
📝 src/fdcache_entity.cpp (+1 -1)
📝 src/s3fs.cpp (+13 -13)
📝 src/string_util.cpp (+33 -39)
📝 src/string_util.h (+3 -2)

📄 Description

Relevant Issue (if applicable)

#2095

Details

Until reported in #2095, there was no example of using characters that require URL encoding in the upload id specified in a multipart upload.
The upload id is passed as a query parameter in the URL, so it should be URL encoded accordingly.
So I changed the process to URL encode the upload id and pass it as a query parameter.

In this amendment, since the functions related to URL encoding become complicated, I have also changed the function names as follows.

before changing	after changing
urlEncode	urlEncodePath
urlEncode2	urlEncodeQuery
-	(new) urlEncodeGeneral

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2097 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 1/22/2023 **Status:** ✅ Merged **Merged:** 2/18/2023 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `encode_uploadid` --- ### 📝 Commits (1) - [`bd8838f`](https://github.com/s3fs-fuse/s3fs-fuse/commit/bd8838f3046a1b894b22dfbc2759a740b223de75) multipart upload id is converted by url encode ### 📊 Changes **6 files changed** (+77 additions, -63 deletions) <details> <summary>View changed files</summary> 📝 `src/curl.cpp` (+26 -7) 📝 `src/curl_util.cpp` (+1 -1) 📝 `src/fdcache_entity.cpp` (+1 -1) 📝 `src/s3fs.cpp` (+13 -13) 📝 `src/string_util.cpp` (+33 -39) 📝 `src/string_util.h` (+3 -2) </details> ### 📄 Description ### Relevant Issue (if applicable) #2095 ### Details Until reported in #2095, there was no example of using characters that require URL encoding in the upload id specified in a multipart upload. The upload id is passed as a query parameter in the URL, so it should be URL encoded accordingly. So I changed the process to URL encode the upload id and pass it as a query parameter. In this amendment, since the functions related to URL encoding become complicated, I have also changed the function names as follows. | before changing | after changing | | --------------- | ---------------- | | urlEncode | urlEncodePath | | urlEncode2 | urlEncodeQuery | | - | (new) urlEncodeGeneral | --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>