[PR #2023] [MERGED] Support the object under no directory object path by compat_dir #2310

Closed
opened 2026-03-04 02:04:51 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2023
Author: @ggtakec
Created: 8/14/2022
Status: Merged
Merged: 10/22/2022
Merged by: @ggtakec

Base: masterHead: no_dir_obj_listing


📝 Commits (1)

  • fb16415 Support the object under no directory object path by compat_dir

📊 Changes

4 files changed (+282 additions, -23 deletions)

View changed files

📝 src/curl_multi.cpp (+22 -4)
📝 src/curl_multi.h (+8 -3)
📝 src/s3fs.cpp (+100 -16)
📝 test/integration-test-main.sh (+152 -0)

📄 Description

Relevant Issue (if applicable)

#2022

Details

About #2022
If user uploads a file that includes a non-existent directory path from the aws command, etc., the stat information(dir/ object) of the intermediate directory does not exist.
So s3fs can not list those directories.
However, user can access files by specifying a file path that includes a directory.
Specifying compat_dir does not change this phenomenon.

This fixes:
Fixed so that when compat_dir is specified, the directory can be listed even if the stat information(dir/ object) of the intermediate directory does not exist.
I have added the test code, but a part of test has not been run because compat_dir is not included in the s3fs boot options(on the test).
However, my manual testing has been performed and it was succeed.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2023 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 8/14/2022 **Status:** ✅ Merged **Merged:** 10/22/2022 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `no_dir_obj_listing` --- ### 📝 Commits (1) - [`fb16415`](https://github.com/s3fs-fuse/s3fs-fuse/commit/fb16415c6b8af3c273d20395ba4976a66d4b0a21) Support the object under no directory object path by compat_dir ### 📊 Changes **4 files changed** (+282 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `src/curl_multi.cpp` (+22 -4) 📝 `src/curl_multi.h` (+8 -3) 📝 `src/s3fs.cpp` (+100 -16) 📝 `test/integration-test-main.sh` (+152 -0) </details> ### 📄 Description ### Relevant Issue (if applicable) #2022 ### Details About #2022 If user uploads a file that includes a non-existent directory path from the aws command, etc., the stat information(`dir/` object) of the intermediate directory does not exist. So s3fs can not list those directories. However, user can access files by specifying a file path that includes a directory. Specifying `compat_dir` does not change this phenomenon. This fixes: Fixed so that when `compat_dir` is specified, the directory can be listed even if the stat information(`dir/` object) of the intermediate directory does not exist. I have added the test code, but a part of test has not been run because `compat_dir` is not included in the s3fs boot options(on the test). However, my manual testing has been performed and it was succeed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-04 02:04:51 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/s3fs-fuse#2310
No description provided.