[PR #2004] [MERGED] Avoid mutating `mybasename` and `mydirname` parameters #2298

New issue

Closed

opened 2026-03-04 02:04:48 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:04:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2004
Author: @gaul
Created: 7/28/2022
Status: ✅ Merged
Merged: 7/28/2022
Merged by: @ggtakec

Base: master ← Head: const_cast

📝 Commits (1)

818a943 Avoid mutating mybasename and mydirname parameters

📊 Changes

1 file changed (+12 additions, -4 deletions)

View changed files

📝 src/s3fs_util.cpp (+12 -4)

📄 Description

basename and dirname mutate their inputs but const_cast hid this
behavior. Also shuffle helpers to avoid unnecessary std::string.
Follows on to 404c284440.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2004 **Author:** [@gaul](https://github.com/gaul) **Created:** 7/28/2022 **Status:** ✅ Merged **Merged:** 7/28/2022 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `const_cast` --- ### 📝 Commits (1) - [`818a943`](https://github.com/s3fs-fuse/s3fs-fuse/commit/818a94327a53426570e1f88501c11fc37353511d) Avoid mutating mybasename and mydirname parameters ### 📊 Changes **1 file changed** (+12 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/s3fs_util.cpp` (+12 -4) </details> ### 📄 Description `basename` and `dirname` mutate their inputs but `const_cast` hid this behavior. Also shuffle helpers to avoid unnecessary `std::string`. Follows on to 404c284440fcbf52671ff703396bd5c22f2f31e3. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>