[PR #1990] [MERGED] Fixed bugs about stream upload #2289

New issue

Closed

opened 2026-03-04 02:04:45 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:04:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1990
Author: @ggtakec
Created: 7/18/2022
Status: ✅ Merged
Merged: 7/19/2022
Merged by: @gaul

Base: master ← Head: fix_stream_upload

📝 Commits (1)

613d2a3 Fixed bugs about stream upload

📊 Changes

5 files changed (+124 additions, -121 deletions)

View changed files

📝 src/fdcache_entity.cpp (+70 -32)
📝 src/fdcache_entity.h (+7 -0)
📝 src/fdcache_fdinfo.cpp (+14 -78)
📝 src/fdcache_fdinfo.h (+6 -11)
📝 src/types.h (+27 -0)

📄 Description

Relevant Issue (if applicable)

#1802

Details

There was a bug in the code merged in #1802, so this PR fixed it.
(The tests for test_truncate_upload and test_upload_sparsefile are failed.)

Fixed this bug

Perhaps the inconvenience was manifested in this stream upload logic after merged #1887.
The range areas which were untreated area was managed by UntreatedParts untreated_list value, which was implemented in the PseudoFdInfo class.
This has been fixed by moving it to the FdEntity class.

Fixed another bug

Along with this fix, I found that there was a possibility of SEGV error, so it was fixed.
It was a problem with pointer management of etagpair structure (which had etag and upload number).
I fixed this by adding and using the petagpool structure.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1990 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 7/18/2022 **Status:** ✅ Merged **Merged:** 7/19/2022 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `fix_stream_upload` --- ### 📝 Commits (1) - [`613d2a3`](https://github.com/s3fs-fuse/s3fs-fuse/commit/613d2a3afa799cc7befb70ea14e4a69fb0254e65) Fixed bugs about stream upload ### 📊 Changes **5 files changed** (+124 additions, -121 deletions) <details> <summary>View changed files</summary> 📝 `src/fdcache_entity.cpp` (+70 -32) 📝 `src/fdcache_entity.h` (+7 -0) 📝 `src/fdcache_fdinfo.cpp` (+14 -78) 📝 `src/fdcache_fdinfo.h` (+6 -11) 📝 `src/types.h` (+27 -0) </details> ### 📄 Description ### Relevant Issue (if applicable) #1802 ### Details There was a bug in the code merged in #1802, so this PR fixed it. (The tests for `test_truncate_upload` and `test_upload_sparsefile` are failed.) #### Fixed this bug Perhaps the inconvenience was manifested in this `stream upload` logic after merged #1887. The range areas which were untreated area was managed by `UntreatedParts untreated_list` value, which was implemented in the `PseudoFdInfo` class. This has been fixed by moving it to the `FdEntity` class. #### Fixed another bug Along with this fix, I found that there was a possibility of SEGV error, so it was fixed. It was a problem with pointer management of `etagpair structure` (which had etag and upload number). I fixed this by adding and using the `petagpool structure`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>