[PR #1950] [CLOSED] fix for segfault while reseting handle for retrying [feat:1948] #2269

New issue

Closed

opened 2026-03-04 02:04:39 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:04:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1950
Author: @ggtakec
Created: 5/25/2022
Status: ❌ Closed

Base: master ← Head: feat_1948

📝 Commits (1)

2a71511 fix for segfault while reseting handle for retrying [feat:1948]

📊 Changes

1 file changed (+16 additions, -9 deletions)

View changed files

📝 src/curl_util.cpp (+16 -9)

📄 Description

Relevant Issue (if applicable)

#1948 #1890

Details

This PR is a remake of #1948 submitted by @nkkashyap with the help of him and @erapetti.

The bug was a problem with the curl_slist_remove function, as noted in the #1948 comment.
We can also prepare test code for this fix, but I think it will require a test program in C++ code.
(I find it difficult to run a test case containing this bug from the s3fs process)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1950 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 5/25/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `feat_1948` --- ### 📝 Commits (1) - [`2a71511`](https://github.com/s3fs-fuse/s3fs-fuse/commit/2a71511ce252c503e05de11e5ec5f502cae19458) fix for segfault while reseting handle for retrying [feat:1948] ### 📊 Changes **1 file changed** (+16 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/curl_util.cpp` (+16 -9) </details> ### 📄 Description ### Relevant Issue (if applicable) #1948 #1890 ### Details This PR is a remake of #1948 submitted by @nkkashyap with the help of him and @erapetti. The bug was a problem with the curl_slist_remove function, as noted in the #1948 comment. We can also prepare test code for this fix, but I think it will require a test program in C++ code. (I find it difficult to run a test case containing this bug from the s3fs process) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>