[PR #1917] [MERGED] Changed handling the credential in S3fsCred more robust #2253

New issue

Closed

opened 2026-03-04 02:04:34 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:04:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1917
Author: @ggtakec
Created: 2/23/2022
Status: ✅ Merged
Merged: 3/2/2022
Merged by: @gaul

Base: master ← Head: s3fscred_for_robust

📝 Commits (1)

db338bf Changed handling the credential in S3fsCred more robust

📊 Changes

5 files changed (+423 additions, -237 deletions)

View changed files

📝 src/curl.cpp (+90 -125)
📝 src/curl.h (+8 -8)
📝 src/s3fs.cpp (+5 -11)
📝 src/s3fs_cred.cpp (+285 -59)
📝 src/s3fs_cred.h (+35 -34)

📄 Description

Relevant Issue (if applicable)

#1878, etc

Details

This PR makes the process of handling s3fs Credentials more concealed and robust to the S3fsCred class.
Also, the acquisition of access key id/secret/token is aggregated in the CheckIAMCredentialUpdate method.

And, until now the process of reacquiring the Token was not exclusively controlled, but it has been changed to use the AutoLock object.

This could be related to #1890.
In #1890, s3fs received a PUT request's response 500 and tried to retry(### retrying ...), after that s3fs caught a segfault.
In the process of retry, insertAuthHeaders () is called by S3fsCurl :: RequestPerform method, and no log is output after that.
If insertAuthHeaders () is involved in this segfault, it may be fixed in this PR.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1917 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 2/23/2022 **Status:** ✅ Merged **Merged:** 3/2/2022 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `s3fscred_for_robust` --- ### 📝 Commits (1) - [`db338bf`](https://github.com/s3fs-fuse/s3fs-fuse/commit/db338bf57c94d6c904541b57682d5be323b255c0) Changed handling the credential in S3fsCred more robust ### 📊 Changes **5 files changed** (+423 additions, -237 deletions) <details> <summary>View changed files</summary> 📝 `src/curl.cpp` (+90 -125) 📝 `src/curl.h` (+8 -8) 📝 `src/s3fs.cpp` (+5 -11) 📝 `src/s3fs_cred.cpp` (+285 -59) 📝 `src/s3fs_cred.h` (+35 -34) </details> ### 📄 Description ### Relevant Issue (if applicable) #1878, etc ### Details This PR makes the process of handling s3fs Credentials more concealed and robust to the S3fsCred class. Also, the acquisition of `access key id`/`secret`/`token` is aggregated in the CheckIAMCredentialUpdate method. And, until now the process of reacquiring the Token was not exclusively controlled, but it has been changed to use the `AutoLock` object. - This could be related to #1890. In #1890, s3fs received a PUT request's response 500 and tried to retry(`### retrying ...`), after that s3fs caught a segfault. In the process of retry, insertAuthHeaders () is called by S3fsCurl :: RequestPerform method, and no log is output after that. If insertAuthHeaders () is involved in this segfault, it may be fixed in this PR. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>