[PR #1887] [MERGED] Fixed not to call Flush even if the file size is increased #2232

New issue

Closed

opened 2026-03-04 02:04:28 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:04:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1887
Author: @ggtakec
Created: 2/13/2022
Status: ✅ Merged
Merged: 2/15/2022
Merged by: @gaul

Base: master ← Head: truncate_optimize

📝 Commits (2)

898dafc Fixed not to call Flush even if the file size is increased
424404a Separated macos-specific processing with ifdef

📊 Changes

3 files changed (+36 additions, -16 deletions)

View changed files

📝 src/fdcache.cpp (+5 -0)
📝 src/fdcache_entity.cpp (+2 -2)
📝 src/s3fs.cpp (+29 -14)

📄 Description

Relevant Issue (if applicable)

#1875

Details

Changed s3fs_truncate function.
This change reduces the number of file uploads if the file size is changed.

On macos, I have found that the truncate call when "size=0" cannot reflect the file size.(This reason is not understood...)
To avoid this, only when "size=0", the flush method is called as before.

Other than that, I found a bug in FdEntity::Open() and fixed it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1887 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 2/13/2022 **Status:** ✅ Merged **Merged:** 2/15/2022 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `truncate_optimize` --- ### 📝 Commits (2) - [`898dafc`](https://github.com/s3fs-fuse/s3fs-fuse/commit/898dafc8cd683214a961fa4752d870a438c5414a) Fixed not to call Flush even if the file size is increased - [`424404a`](https://github.com/s3fs-fuse/s3fs-fuse/commit/424404af7d985698a77da2fcc60ba3687eeee969) Separated macos-specific processing with ifdef ### 📊 Changes **3 files changed** (+36 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `src/fdcache.cpp` (+5 -0) 📝 `src/fdcache_entity.cpp` (+2 -2) 📝 `src/s3fs.cpp` (+29 -14) </details> ### 📄 Description ### Relevant Issue (if applicable) #1875 ### Details Changed s3fs_truncate function. This change reduces the number of file uploads if the file size is changed. On macos, I have found that the truncate call when "size=0" cannot reflect the file size.(This reason is not understood...) To avoid this, only when "size=0", the flush method is called as before. Other than that, I found a bug in FdEntity::Open() and fixed it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>