[PR #1885] [MERGED] Fixed test_external_directory_creation test when cache enabled #2230

New issue

Closed

opened 2026-03-04 02:04:27 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:04:27 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1885
Author: @ggtakec
Created: 2/6/2022
Status: ✅ Merged
Merged: 2/13/2022
Merged by: @ggtakec

Base: master ← Head: fix_test_ext_mod

📝 Commits (1)

8f93090 Fixed test_external_directory_creation test when cache enabled

📊 Changes

1 file changed (+11 additions, -0 deletions)

View changed files

📝 test/integration-test-main.sh (+11 -0)

📄 Description

Relevant Issue (if applicable)

#1884

Details

It is a correction of the defect detected by the correction of #1884.

The test_external_modification test checks the reflection of the updated file from the external program (awscli).

However, if s3fs currently has the stat cache and cache directory enabled, this test will fail.
This is because the time value of the file timestamp does not change before and after the change.
When using the stat cache and the file does not update after modifying, the cache hit and reading contents from local cache file.
Then the test is failed.
To fix this test, use sleep in test_external_modification.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1885 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 2/6/2022 **Status:** ✅ Merged **Merged:** 2/13/2022 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `fix_test_ext_mod` --- ### 📝 Commits (1) - [`8f93090`](https://github.com/s3fs-fuse/s3fs-fuse/commit/8f930902090ba50fcca4ea874525b7e9c4e51b22) Fixed test_external_directory_creation test when cache enabled ### 📊 Changes **1 file changed** (+11 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `test/integration-test-main.sh` (+11 -0) </details> ### 📄 Description ### Relevant Issue (if applicable) #1884 ### Details It is a correction of the defect detected by the correction of #1884. The `test_external_modification` test checks the reflection of the updated file from the external program (awscli). However, if s3fs currently has the stat cache and cache directory enabled, this test will fail. This is because the time value of the file timestamp does not change before and after the change. When using the stat cache and the file does not update after modifying, the cache hit and reading contents from local cache file. Then the test is failed. _To fix this test, use sleep in `test_external_modification`._ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>