[PR #1878] [MERGED] Added S3fsCred class and moved Credential related processing in it #2223

New issue

Closed

opened 2026-03-04 02:04:25 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:04:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1878
Author: @ggtakec
Created: 1/30/2022
Status: ✅ Merged
Merged: 2/13/2022
Merged by: @gaul

Base: master ← Head: cred_class

📝 Commits (1)

0f480f2 Added S3fsCred class and moved Credential related processing in it

📊 Changes

13 files changed (+1254 additions, -917 deletions)

View changed files

📝 src/Makefile.am (+1 -0)
📝 src/common.h (+0 -2)
📝 src/curl.cpp (+63 -298)
📝 src/curl.h (+4 -46)
📝 src/curl_util.cpp (+6 -5)
📝 src/fdcache.cpp (+6 -5)
📝 src/fdcache_entity.cpp (+1 -1)
📝 src/fdcache_stat.cpp (+3 -2)
📝 src/s3fs.cpp (+68 -556)
➕ src/s3fs_cred.cpp (+920 -0)
➕ src/s3fs_cred.h (+154 -0)
📝 src/s3fs_global.cpp (+0 -2)
📝 src/test_curl_util.cpp (+28 -0)

📄 Description

Relevant Issue (if applicable)

n/a

Details

In current s3fs, Management of Credential(or AccessKey, Token, etc) processing and options(variables) for server is scattered in s3fs.cpp and S3fsCurl classes, etc.
These variables, functions, etc. should be grouped in new S3fsCred class so that information related to Credentials can be centrally managed.

With this PR code, I didn't change about the logic, I just aggregated those into new S3fsCred class.

NOTE

I think this is necessary in the feture because the code become complicated for the support for aws-sdk-cpp and other providers different from AWS S3.
If necessary, it is possible to modify this class, such as separating it into a base class and a derived class.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1878 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 1/30/2022 **Status:** ✅ Merged **Merged:** 2/13/2022 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `cred_class` --- ### 📝 Commits (1) - [`0f480f2`](https://github.com/s3fs-fuse/s3fs-fuse/commit/0f480f2d6ac393b977e595583b44982e52bdf377) Added S3fsCred class and moved Credential related processing in it ### 📊 Changes **13 files changed** (+1254 additions, -917 deletions) <details> <summary>View changed files</summary> 📝 `src/Makefile.am` (+1 -0) 📝 `src/common.h` (+0 -2) 📝 `src/curl.cpp` (+63 -298) 📝 `src/curl.h` (+4 -46) 📝 `src/curl_util.cpp` (+6 -5) 📝 `src/fdcache.cpp` (+6 -5) 📝 `src/fdcache_entity.cpp` (+1 -1) 📝 `src/fdcache_stat.cpp` (+3 -2) 📝 `src/s3fs.cpp` (+68 -556) ➕ `src/s3fs_cred.cpp` (+920 -0) ➕ `src/s3fs_cred.h` (+154 -0) 📝 `src/s3fs_global.cpp` (+0 -2) 📝 `src/test_curl_util.cpp` (+28 -0) </details> ### 📄 Description ### Relevant Issue (if applicable) n/a ### Details In current s3fs, Management of Credential(or AccessKey, Token, etc) processing and options(variables) for server is scattered in s3fs.cpp and S3fsCurl classes, etc. These variables, functions, etc. should be grouped in new S3fsCred class so that information related to Credentials can be centrally managed. With this PR code, I didn't change about the logic, I just aggregated those into new S3fsCred class. #### NOTE I think this is necessary in the feture because the code become complicated for the support for aws-sdk-cpp and other providers different from AWS S3. If necessary, it is possible to modify this class, such as separating it into a base class and a derived class. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>