[PR #1789] [MERGED] Fixed a bug that copied without considering the length of xmlChar #2174

New issue

Closed

opened 2026-03-04 02:04:08 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:04:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1789
Author: @ggtakec
Created: 10/26/2021
Status: ✅ Merged
Merged: 10/26/2021
Merged by: @gaul

Base: master ← Head: fix_bug_xmlchar

📝 Commits (4)

250002e Fixed a bug that copied without considering the length of xmlChar
5bb2566 Added exclusive control of statc variables in s3fs xml parser
8403f42 Added exclusive control of statc variables in s3fs xml parser
f2b3c62 Merge branch 'master' into fix_bug_xmlchar

📊 Changes

3 files changed (+102 additions, -17 deletions)

View changed files

📝 src/s3fs.cpp (+27 -0)
📝 src/s3fs_xml.cpp (+72 -17)
📝 src/s3fs_xml.h (+3 -0)

📄 Description

Relevant Issue (if applicable)

#1771 #1772

Details

When copying the string of xmlChar to std::string, the end of the original string cannot be caught.
xmlChar is unsigned char* and also supports UTF8 strings.
Therefore, I checked the length of xmlChar with xmlStrlen and modified it to copy.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1789 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 10/26/2021 **Status:** ✅ Merged **Merged:** 10/26/2021 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `fix_bug_xmlchar` --- ### 📝 Commits (4) - [`250002e`](https://github.com/s3fs-fuse/s3fs-fuse/commit/250002ee7352d3c4d15a5c5f94224b23613a924a) Fixed a bug that copied without considering the length of xmlChar - [`5bb2566`](https://github.com/s3fs-fuse/s3fs-fuse/commit/5bb2566bd51531492ad5674dc65b83f60c9f5efb) Added exclusive control of statc variables in s3fs xml parser - [`8403f42`](https://github.com/s3fs-fuse/s3fs-fuse/commit/8403f4253cb2e891a78ed9d6a56ed0d692a0783d) Added exclusive control of statc variables in s3fs xml parser - [`f2b3c62`](https://github.com/s3fs-fuse/s3fs-fuse/commit/f2b3c62c4a23da501384472e0899d3fcb4be7597) Merge branch 'master' into fix_bug_xmlchar ### 📊 Changes **3 files changed** (+102 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `src/s3fs.cpp` (+27 -0) 📝 `src/s3fs_xml.cpp` (+72 -17) 📝 `src/s3fs_xml.h` (+3 -0) </details> ### 📄 Description ### Relevant Issue (if applicable) #1771 #1772 ### Details When copying the string of `xmlChar` to `std::string`, the end of the original string cannot be caught. xmlChar is `unsigned char*` and also supports UTF8 strings. Therefore, I checked the length of `xmlChar` with `xmlStrlen` and modified it to copy. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>