[PR #1773] [MERGED] Fixed forgetting to clear the dirty flag for meta information #2161

New issue

Closed

opened 2026-03-04 02:04:05 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:04:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1773
Author: @ggtakec
Created: 10/7/2021
Status: ✅ Merged
Merged: 10/15/2021
Merged by: @gaul

Base: master ← Head: fix_bug

📝 Commits (1)

ace7c7f Fixed forgetting to clear the dirty flag for meta information

📊 Changes

6 files changed (+18 additions, -11 deletions)

View changed files

📝 src/curl.cpp (+4 -4)
📝 src/curl.h (+4 -4)
📝 src/fdcache_entity.cpp (+6 -1)
📝 src/fdcache_entity.h (+1 -1)
📝 src/fdcache_page.cpp (+1 -1)
📝 src/s3fs_xml.cpp (+2 -0)

📄 Description

Relevant Issue (if applicable)

n/a

Details

In the case where the dirty flag was set for the meta information, there was a case where this flag was not reset.
If s3fs started a file upload(containing a multipart upload) when flushed, this flag could not be reset.

Also, a new error was reported in cppcheck, so I fixed it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1773 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 10/7/2021 **Status:** ✅ Merged **Merged:** 10/15/2021 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `fix_bug` --- ### 📝 Commits (1) - [`ace7c7f`](https://github.com/s3fs-fuse/s3fs-fuse/commit/ace7c7f182ede610f5bd15b661bda392fdb53da8) Fixed forgetting to clear the dirty flag for meta information ### 📊 Changes **6 files changed** (+18 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `src/curl.cpp` (+4 -4) 📝 `src/curl.h` (+4 -4) 📝 `src/fdcache_entity.cpp` (+6 -1) 📝 `src/fdcache_entity.h` (+1 -1) 📝 `src/fdcache_page.cpp` (+1 -1) 📝 `src/s3fs_xml.cpp` (+2 -0) </details> ### 📄 Description ### Relevant Issue (if applicable) n/a ### Details In the case where the dirty flag was set for the meta information, there was a case where this flag was not reset. If s3fs started a file upload(containing a multipart upload) when flushed, this flag could not be reset. Also, a new error was reported in cppcheck, so I fixed it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>