[PR #1742] [MERGED] Changed etaglist_t from string list to new structure etagpairs list #2150

New issue

Closed

opened 2026-03-04 02:04:00 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:04:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1742
Author: @ggtakec
Created: 8/15/2021
Status: ✅ Merged
Merged: 8/16/2021
Merged by: @gaul

Base: master ← Head: change_etaglist

📝 Commits (1)

0ce4f4a Changed etaglist_t from string list to new structure etagpairs list

📊 Changes

6 files changed (+77 additions, -47 deletions)

View changed files

📝 src/curl.cpp (+23 -24)
📝 src/curl.h (+1 -1)
📝 src/fdcache_entity.cpp (+3 -4)
📝 src/fdcache_fdinfo.cpp (+8 -9)
📝 src/fdcache_fdinfo.h (+2 -2)
📝 src/types.h (+40 -7)

📄 Description

Relevant Issue (if applicable)

n/a

Details

Changed the etaglist_t element that stores a list of ETag values for multipart uploads.

The etaglist_t was a list of std::string, but I changed it to a list of newly added structure etagpair.

For multipart uploads, the ETag and part number must be a pair.
Currently, these are managed separately, but that has no problem.
That's because each part of the multipart is a sequential number and matches the position of the string list etaglist_t.

In this PR, we have added a new structure etagpair with ETag and part number as members.
And I changed etaglist_t to a list of structs etagpair.

This PR is a related modification.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1742 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 8/15/2021 **Status:** ✅ Merged **Merged:** 8/16/2021 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `change_etaglist` --- ### 📝 Commits (1) - [`0ce4f4a`](https://github.com/s3fs-fuse/s3fs-fuse/commit/0ce4f4a126191e89943ff67a61663bfee03d49ad) Changed etaglist_t from string list to new structure etagpairs list ### 📊 Changes **6 files changed** (+77 additions, -47 deletions) <details> <summary>View changed files</summary> 📝 `src/curl.cpp` (+23 -24) 📝 `src/curl.h` (+1 -1) 📝 `src/fdcache_entity.cpp` (+3 -4) 📝 `src/fdcache_fdinfo.cpp` (+8 -9) 📝 `src/fdcache_fdinfo.h` (+2 -2) 📝 `src/types.h` (+40 -7) </details> ### 📄 Description ### Relevant Issue (if applicable) n/a ### Details Changed the etaglist_t element that stores a list of `ETag` values for multipart uploads. The etaglist_t was a list of `std::string`, but I changed it to a list of newly added structure `etagpair`. For multipart uploads, the `ETag` and `part number` must be a pair. Currently, these are managed separately, but that has no problem. That's because each part of the multipart is a sequential number and matches the position of the string `list etaglist_t`. In this PR, we have added a new structure `etagpair` with `ETag` and `part number` as members. And I changed `etaglist_t` to a list of structs `etagpair`. This PR is a related modification. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>