[PR #1727] [MERGED] Added fake_diskfree option to deceive free disk space for test #2143

New issue

Closed

opened 2026-03-04 02:03:58 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:03:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1727
Author: @ggtakec
Created: 7/22/2021
Status: ✅ Merged
Merged: 8/2/2021
Merged by: @gaul

Base: master ← Head: add_fake_diskfree_opt

📝 Commits (1)

b274b3d Added fake_diskfree option to deceive free disk space for test

📊 Changes

4 files changed (+38 additions, -16 deletions)

View changed files

📝 src/fdcache.cpp (+19 -1)
📝 src/fdcache.h (+3 -1)
📝 src/s3fs.cpp (+13 -0)
📝 test/small-integration-test.sh (+3 -14)

📄 Description

Relevant Issue (if applicable)

#1722

Details

The ensure_diskfree option is an option to protect the free disk space.
The reason for not checking the disk usage of s3fs is that it causes performance degradation. (like the du command)
So that s3fs is using disk stat information will improve performance.
That's why we provide the ensure_diskfree option.

However, there are some issues that are very difficult to test, such as Github Actions.
This is because the Runner(VM, HOST, etc) have different capacities, so the same value cannot be used for the ensure_diskfree option.

To avoid this situation, we have added the option fake_diskfree to deceive free disk space.
The value of this option is stored as free disk space when s3fs is started, and after that, this value(difference from the actual free disk space) will be used.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1727 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 7/22/2021 **Status:** ✅ Merged **Merged:** 8/2/2021 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `add_fake_diskfree_opt` --- ### 📝 Commits (1) - [`b274b3d`](https://github.com/s3fs-fuse/s3fs-fuse/commit/b274b3de5814f7d329b0ae8b109ea850e55e002f) Added fake_diskfree option to deceive free disk space for test ### 📊 Changes **4 files changed** (+38 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `src/fdcache.cpp` (+19 -1) 📝 `src/fdcache.h` (+3 -1) 📝 `src/s3fs.cpp` (+13 -0) 📝 `test/small-integration-test.sh` (+3 -14) </details> ### 📄 Description ### Relevant Issue (if applicable) #1722 ### Details The `ensure_diskfree` option is an option to protect the free disk space. The reason for not checking the disk usage of s3fs is that it causes performance degradation. (like the `du` command) So that s3fs is using disk stat information will improve performance. That's why we provide the `ensure_diskfree` option. However, there are some issues that are very difficult to test, such as Github Actions. This is because the Runner(VM, HOST, etc) have different capacities, so the same value cannot be used for the `ensure_diskfree` option. To avoid this situation, we have added the option `fake_diskfree` to deceive free disk space. The value of this option is stored as free disk space when s3fs is started, and after that, this value(difference from the actual free disk space) will be used. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>