[PR #1719] [MERGED] Added UntreatedParts class instead of untreated upload info members in PseudoFdInfo #2137

New issue

Closed

opened 2026-03-04 02:03:57 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:03:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1719
Author: @ggtakec
Created: 7/11/2021
Status: ✅ Merged
Merged: 7/12/2021
Merged by: @gaul

Base: master ← Head: add_untreatedpart

📝 Commits (1)

38c40f1 Added UntreatedParts class instead of untreated upload info members in PseudoFdInfo

📊 Changes

7 files changed (+459 additions, -38 deletions)

View changed files

📝 src/Makefile.am (+1 -0)
📝 src/fdcache_entity.cpp (+24 -23)
📝 src/fdcache_fdinfo.cpp (+17 -10)
📝 src/fdcache_fdinfo.h (+8 -4)
➕ src/fdcache_untreated.cpp (+284 -0)
➕ src/fdcache_untreated.h (+70 -0)
📝 src/types.h (+55 -1)

📄 Description

Relevant Issue (if applicable)

#1666

Details

This PR is an ongoing fix since #1666.

The PseudoFdInfo class has member variables(untreated_start, untreated_size) that are not currently used(values are set but not used effectively).
This variable was added in #1666 to indicate an unprocessed area that has been written to a file but has not yet been uploaded.

The information that this variable should have is more complex and cannot be represented by a simple variable.
So add the UntreatedParts class and use untreated_list instead of untreated_start and untreated_size.

Please note that this untreated_list variable has not yet been enabled.(I plan to use it effectively in future implementations of stream upload.)

Note that this fix should not affect existing behavior.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1719 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 7/11/2021 **Status:** ✅ Merged **Merged:** 7/12/2021 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `add_untreatedpart` --- ### 📝 Commits (1) - [`38c40f1`](https://github.com/s3fs-fuse/s3fs-fuse/commit/38c40f13cbbb5b553e788ef675b7692074cdf29f) Added UntreatedParts class instead of untreated upload info members in PseudoFdInfo ### 📊 Changes **7 files changed** (+459 additions, -38 deletions) <details> <summary>View changed files</summary> 📝 `src/Makefile.am` (+1 -0) 📝 `src/fdcache_entity.cpp` (+24 -23) 📝 `src/fdcache_fdinfo.cpp` (+17 -10) 📝 `src/fdcache_fdinfo.h` (+8 -4) ➕ `src/fdcache_untreated.cpp` (+284 -0) ➕ `src/fdcache_untreated.h` (+70 -0) 📝 `src/types.h` (+55 -1) </details> ### 📄 Description ### Relevant Issue (if applicable) #1666 ### Details This PR is an ongoing fix since #1666. The `PseudoFdInfo` class has member variables(`untreated_start`, `untreated_size`) that are not currently used(values are set but not used effectively). This variable was added in #1666 to indicate an unprocessed area that has been written to a file but has not yet been uploaded. The information that this variable should have is more complex and cannot be represented by a simple variable. So add the `UntreatedParts` class and use `untreated_list` instead of `untreated_start` and `untreated_size`. Please note that this `untreated_list` variable has not yet been enabled.(I plan to use it effectively in future implementations of stream upload.) Note that this fix should not affect existing behavior. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>