[PR #1683] [MERGED] Require explicit base parameter in cvt_strtoofft #2113

New issue

Closed

opened 2026-03-04 02:03:46 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:03:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1683
Author: @gaul
Created: 6/16/2021
Status: ✅ Merged
Merged: 6/20/2021
Merged by: @ggtakec

Base: master ← Head: base-10

📝 Commits (1)

7692122 Require explicit base parameter in cvt_strtoofft

📊 Changes

3 files changed (+24 additions, -24 deletions)

View changed files

📝 src/metaheader.cpp (+5 -5)
📝 src/s3fs.cpp (+18 -18)
📝 src/string_util.h (+1 -1)

📄 Description

Also convert most callers of cvt_strtoofft to base 10 which avoid the
magical behavior of interpreting a leading 0 as octal.
References #1682.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1683 **Author:** [@gaul](https://github.com/gaul) **Created:** 6/16/2021 **Status:** ✅ Merged **Merged:** 6/20/2021 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `base-10` --- ### 📝 Commits (1) - [`7692122`](https://github.com/s3fs-fuse/s3fs-fuse/commit/76921227efd3b7e277a80613104de44dffc941c5) Require explicit base parameter in cvt_strtoofft ### 📊 Changes **3 files changed** (+24 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `src/metaheader.cpp` (+5 -5) 📝 `src/s3fs.cpp` (+18 -18) 📝 `src/string_util.h` (+1 -1) </details> ### 📄 Description Also convert most callers of `cvt_strtoofft` to base 10 which avoid the magical behavior of interpreting a leading 0 as octal. References #1682. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>