[PR #1673] [MERGED] Prefer std::string::rbegin over operator[] #2108

New issue

Closed

opened 2026-03-04 02:03:44 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:03:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1673
Author: @gaul
Created: 6/5/2021
Status: ✅ Merged
Merged: 6/13/2021
Merged by: @ggtakec

Base: master ← Head: rbegin

📝 Commits (1)

4d35217 Prefer std::string::rbegin over operator[]

📊 Changes

5 files changed (+22 additions, -22 deletions)

View changed files

📝 src/cache.cpp (+3 -3)
📝 src/curl_util.cpp (+2 -2)
📝 src/s3fs.cpp (+12 -12)
📝 src/s3fs_xml.cpp (+1 -1)
📝 src/s3objlist.cpp (+4 -4)

📄 Description

This is more concise and safer due to not repeating the variable name.
We cannot use std::string::back since it is not available in C++03.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1673 **Author:** [@gaul](https://github.com/gaul) **Created:** 6/5/2021 **Status:** ✅ Merged **Merged:** 6/13/2021 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `rbegin` --- ### 📝 Commits (1) - [`4d35217`](https://github.com/s3fs-fuse/s3fs-fuse/commit/4d3521757579e0144819857da111be597db9574e) Prefer std::string::rbegin over operator[] ### 📊 Changes **5 files changed** (+22 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `src/cache.cpp` (+3 -3) 📝 `src/curl_util.cpp` (+2 -2) 📝 `src/s3fs.cpp` (+12 -12) 📝 `src/s3fs_xml.cpp` (+1 -1) 📝 `src/s3objlist.cpp` (+4 -4) </details> ### 📄 Description This is more concise and safer due to not repeating the variable name. We cannot use `std::string::back` since it is not available in C++03. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>