[PR #1670] [MERGED] Correct usage of istringstream #2105

New issue

Closed

opened 2026-03-04 02:03:43 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:03:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1670
Author: @gaul
Created: 5/31/2021
Status: ✅ Merged
Merged: 6/1/2021
Merged by: @ggtakec

Base: master ← Head: sstream

📝 Commits (1)

4984d89 Correct usage of istringstream

📊 Changes

1 file changed (+2 additions, -6 deletions)

View changed files

📝 src/curl.cpp (+2 -6)

📄 Description

Previously this looped one more time than necessary due to the eof
check:

https://isocpp.org/wiki/faq/input-output#istream-and-eof

Remove now redundant empty check.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1670 **Author:** [@gaul](https://github.com/gaul) **Created:** 5/31/2021 **Status:** ✅ Merged **Merged:** 6/1/2021 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `sstream` --- ### 📝 Commits (1) - [`4984d89`](https://github.com/s3fs-fuse/s3fs-fuse/commit/4984d898edffd6d910b46df4e6376a0fa42ee1ac) Correct usage of istringstream ### 📊 Changes **1 file changed** (+2 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/curl.cpp` (+2 -6) </details> ### 📄 Description Previously this looped one more time than necessary due to the `eof` check: https://isocpp.org/wiki/faq/input-output#istream-and-eof Remove now redundant `empty` check. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>