[PR #1664] [MERGED] Fixed a bug when the disk capacity was insufficient in RowFlush #2100

New issue

Closed

opened 2026-03-04 02:03:42 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:03:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1664
Author: @ggtakec
Created: 5/21/2021
Status: ✅ Merged
Merged: 5/22/2021
Merged by: @gaul

Base: master ← Head: fix_flush_nospc

📝 Commits (1)

ebd73b1 Fixed a bug when the disk capacity was insufficient in RowFlush

📊 Changes

1 file changed (+21 additions, -12 deletions)

View changed files

📝 src/fdcache_entity.cpp (+21 -12)

📄 Description

Relevant Issue (if applicable)

n/a

Details

I found a bug in the FdEntity::RowFlush method and fixed it.
It was forgot to start multipart upload in the process when it detected that the disk space was insufficient.
The current test was unable to detect this bug because it had to detect out of disk space just when flushing.
The test case for this will be difficult, though we need to think about it in the future.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1664 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 5/21/2021 **Status:** ✅ Merged **Merged:** 5/22/2021 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `fix_flush_nospc` --- ### 📝 Commits (1) - [`ebd73b1`](https://github.com/s3fs-fuse/s3fs-fuse/commit/ebd73b1ce7c39422bb46af365b6dea889df51368) Fixed a bug when the disk capacity was insufficient in RowFlush ### 📊 Changes **1 file changed** (+21 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `src/fdcache_entity.cpp` (+21 -12) </details> ### 📄 Description ### Relevant Issue (if applicable) n/a ### Details I found a bug in the FdEntity::RowFlush method and fixed it. It was forgot to start multipart upload in the process when it detected that the disk space was insufficient. The current test was unable to detect this bug because it had to detect out of disk space just when flushing. The test case for this will be difficult, though we need to think about it in the future. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>