[PR #1649] [MERGED] Replace snprintf with string and ostringstream #2094

New issue

Closed

opened 2026-03-04 02:03:40 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:03:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1649
Author: @gaul
Created: 5/6/2021
Status: ✅ Merged
Merged: 5/7/2021
Merged by: @ggtakec

Base: master ← Head: snprintf

📝 Commits (1)

2bb6308 Replace snprintf with string and ostringstream

📊 Changes

5 files changed (+33 additions, -41 deletions)

View changed files

📝 src/curl.cpp (+2 -4)
📝 src/fdcache.cpp (+1 -1)
📝 src/s3fs_logger.cpp (+22 -1)
📝 src/s3fs_logger.h (+6 -32)
📝 src/string_util.cpp (+2 -3)

📄 Description

These uses are probably safe from a buffer overflow perspective but
can cause data race issues in logging due to static buffers.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1649 **Author:** [@gaul](https://github.com/gaul) **Created:** 5/6/2021 **Status:** ✅ Merged **Merged:** 5/7/2021 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `snprintf` --- ### 📝 Commits (1) - [`2bb6308`](https://github.com/s3fs-fuse/s3fs-fuse/commit/2bb6308bee7c84d2c5051a4f3e643ebae9215956) Replace snprintf with string and ostringstream ### 📊 Changes **5 files changed** (+33 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `src/curl.cpp` (+2 -4) 📝 `src/fdcache.cpp` (+1 -1) 📝 `src/s3fs_logger.cpp` (+22 -1) 📝 `src/s3fs_logger.h` (+6 -32) 📝 `src/string_util.cpp` (+2 -3) </details> ### 📄 Description These uses are probably safe from a buffer overflow perspective but can cause data race issues in logging due to static buffers. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>