[PR #1650] [MERGED] Fixed make_random_string test code being slow on macos #2091

New issue

Closed

opened 2026-03-04 02:03:40 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:03:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1650
Author: @ggtakec
Created: 5/6/2021
Status: ✅ Merged
Merged: 5/8/2021
Merged by: @gaul

Base: master ← Head: fix_test

📝 Commits (1)

406c98c Fixed make_random_string test code being slow on macos

📊 Changes

2 files changed (+7 additions, -10 deletions)

View changed files

📝 test/integration-test-main.sh (+1 -8)
📝 test/test-utils.sh (+6 -2)

📄 Description

Relevant Issue (if applicable)

#1586

Details

I noticed that the make_random_string function in my test code is very slow on macos.
When I executed cat / dev / urandom | base64....., it used a lot of CPU and memory, and it took a lot of execution time.
This was also the reason why #1586 bypassed the test_update_metadata_external_large_object test.
With this fix, even if you re-add the bypassed test, the test time will be shorter.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1650 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 5/6/2021 **Status:** ✅ Merged **Merged:** 5/8/2021 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `fix_test` --- ### 📝 Commits (1) - [`406c98c`](https://github.com/s3fs-fuse/s3fs-fuse/commit/406c98c2ca46bf0a66fd0d432384b27fe16702b4) Fixed make_random_string test code being slow on macos ### 📊 Changes **2 files changed** (+7 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `test/integration-test-main.sh` (+1 -8) 📝 `test/test-utils.sh` (+6 -2) </details> ### 📄 Description ### Relevant Issue (if applicable) #1586 ### Details I noticed that the make_random_string function in my test code is very slow on macos. When I executed `cat / dev / urandom | base64.....`, it used a lot of CPU and memory, and it took a lot of execution time. This was also the reason why #1586 bypassed the test_update_metadata_external_large_object test. With this fix, even if you re-add the bypassed test, the test time will be shorter. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>