[PR #1640] [MERGED] Do not create zero-byte object when creating file #2084

Closed
opened 2026-03-04 02:03:36 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1640
Author: @gaul
Created: 4/29/2021
Status: Merged
Merged: 4/30/2021
Merged by: @ggtakec

Base: masterHead: zero-byte-blob


📝 Commits (1)

  • eb92fe9 Do not create zero-byte object when creating file

📊 Changes

3 files changed (+35 additions, -6 deletions)

View changed files

📝 src/fdcache_entity.h (+6 -0)
📝 src/s3fs.cpp (+14 -6)
📝 test/integration-test-main.sh (+15 -0)

📄 Description

Previously s3fs created this object to store metadata and overwrote it
when flushing. This prevented use with object stores which do not
allow overwrites like HDS. Instead only create an in-memory
representation which reduces the time to create small files.
Fixes #1013.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1640 **Author:** [@gaul](https://github.com/gaul) **Created:** 4/29/2021 **Status:** ✅ Merged **Merged:** 4/30/2021 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `zero-byte-blob` --- ### 📝 Commits (1) - [`eb92fe9`](https://github.com/s3fs-fuse/s3fs-fuse/commit/eb92fe93ec366479da6aa03bf68e1a29f423f5d5) Do not create zero-byte object when creating file ### 📊 Changes **3 files changed** (+35 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/fdcache_entity.h` (+6 -0) 📝 `src/s3fs.cpp` (+14 -6) 📝 `test/integration-test-main.sh` (+15 -0) </details> ### 📄 Description Previously s3fs created this object to store metadata and overwrote it when flushing. This prevented use with object stores which do not allow overwrites like HDS. Instead only create an in-memory representation which reduces the time to create small files. Fixes #1013. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-04 02:03:36 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/s3fs-fuse#2084
No description provided.