[PR #1572] [MERGED] Added no_time_stamp_ms option mainly for testing #2054

New issue

Closed

opened 2026-03-04 02:03:27 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:03:27 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1572
Author: @ggtakec
Created: 2/13/2021
Status: ✅ Merged
Merged: 2/20/2021
Merged by: @gaul

Base: master ← Head: notimestamp

📝 Commits (2)

6bb15ae Added no_time_stamp_ms option mainly for testing
fcfe9b8 Merge branch 'master' into notimestamp

📊 Changes

6 files changed (+64 additions, -20 deletions)

View changed files

📝 doc/man/s3fs.1 (+5 -0)
📝 src/s3fs.cpp (+7 -0)
📝 src/s3fs_help.cpp (+7 -0)
📝 src/s3fs_logger.cpp (+21 -4)
📝 src/s3fs_logger.h (+23 -16)
📝 test/integration-test-common.sh (+1 -0)

📄 Description

Relevant Issue (if applicable)

n/a

Details

The main purpose of this PR is to reduce test time.(Although it may not make a big difference)
We added a time stamp to the debug message output by s3fs, but it seems that the test was slow on OSX which CLOCK_MONOTONIC_COARSE cannot be used.
And I sometimes get an error from filter-suite-log.sh, so I would like to remove the time stamp when testing.
I don't think the time stamp is necessary for the s3fs-fuse test itself, so I don't want to output the time stamp during the test.

Thus, I added the startup option no_time_stamp_msg.
I also added S3FS_MSGTIMESTAMP environment, which plays the same function.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1572 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 2/13/2021 **Status:** ✅ Merged **Merged:** 2/20/2021 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `notimestamp` --- ### 📝 Commits (2) - [`6bb15ae`](https://github.com/s3fs-fuse/s3fs-fuse/commit/6bb15ae7cbafe59fa2f5522b1f96d7880b624aa7) Added no_time_stamp_ms option mainly for testing - [`fcfe9b8`](https://github.com/s3fs-fuse/s3fs-fuse/commit/fcfe9b8527b9476d0758fa745c3859311549f420) Merge branch 'master' into notimestamp ### 📊 Changes **6 files changed** (+64 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `doc/man/s3fs.1` (+5 -0) 📝 `src/s3fs.cpp` (+7 -0) 📝 `src/s3fs_help.cpp` (+7 -0) 📝 `src/s3fs_logger.cpp` (+21 -4) 📝 `src/s3fs_logger.h` (+23 -16) 📝 `test/integration-test-common.sh` (+1 -0) </details> ### 📄 Description ### Relevant Issue (if applicable) n/a ### Details The main purpose of this PR is to reduce test time.(Although it may not make a big difference) We added a time stamp to the debug message output by s3fs, but it seems that the test was slow on OSX which `CLOCK_MONOTONIC_COARSE` cannot be used. And I sometimes get an error from `filter-suite-log.sh`, so I would like to remove the time stamp when testing. I don't think the time stamp is necessary for the s3fs-fuse test itself, so I don't want to output the time stamp during the test. Thus, I added the startup option no_time_stamp_msg. I also added `S3FS_MSGTIMESTAMP` environment, which plays the same function. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>