[PR #1565] [MERGED] set IsExpireTime to true by default #2049

Closed
opened 2026-03-04 02:03:26 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1565
Author: @lincheney
Created: 2/12/2021
Status: Merged
Merged: 2/12/2021
Merged by: @gaul

Base: masterHead: lincheney-patch-1


📝 Commits (1)

  • 3988101 set IsExpireTime to true by default

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/cache.cpp (+1 -1)

📄 Description

fixes #1563

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.
#1563

Details

Please describe the details of PullRequest.
Sets the stat cache IsExpireTime to true by default, so that the default ExpireTime actually takes effect.

Tested using:

  1. Run s3fs: s3fs -f bucket /mountpoint ... without the -o stat_cache_expire option
  2. Create a file in S3: echo | aws cp - s3://bucket/test-file
  3. Run: ls -l /mountpoint/test-file
  4. Remove the file from S3: aws rm s3://bucket/test-file
  5. Wait for more than 15min. (During this time, s3fs will still report the file as existing)
  6. Run: ls -l /mountpoint/test-file . This should print No such file or directory

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1565 **Author:** [@lincheney](https://github.com/lincheney) **Created:** 2/12/2021 **Status:** ✅ Merged **Merged:** 2/12/2021 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `lincheney-patch-1` --- ### 📝 Commits (1) - [`3988101`](https://github.com/s3fs-fuse/s3fs-fuse/commit/39881011894c221099a999667149878a8fc849d4) set IsExpireTime to true by default ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/cache.cpp` (+1 -1) </details> ### 📄 Description fixes #1563 ### Relevant Issue (if applicable) _If there are Issues related to this PullRequest, please list it._ #1563 ### Details _Please describe the details of PullRequest._ Sets the stat cache `IsExpireTime` to `true` by default, so that the default `ExpireTime` actually takes effect. Tested using: 1. Run s3fs: `s3fs -f bucket /mountpoint ...` *without* the `-o stat_cache_expire` option 2. Create a file in S3: `echo | aws cp - s3://bucket/test-file` 3. Run: `ls -l /mountpoint/test-file` 4. Remove the file from S3: `aws rm s3://bucket/test-file` 5. Wait for more than 15min. (During this time, s3fs will still report the file as existing) 6. Run: `ls -l /mountpoint/test-file` . This should print `No such file or directory` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-04 02:03:26 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/s3fs-fuse#2049
No description provided.