[PR #1520] [MERGED] Return more specific errno when available #2026

New issue

Closed

opened 2026-03-04 02:03:20 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:03:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1520
Author: @gaul
Created: 1/16/2021
Status: ✅ Merged
Merged: 1/18/2021
Merged by: @ggtakec

Base: master ← Head: errno

📝 Commits (1)

93b3d0e Return more specific errno when available

📊 Changes

2 files changed (+60 additions, -59 deletions)

View changed files

📝 src/curl.cpp (+30 -30)
📝 src/s3fs.cpp (+30 -29)

📄 Description

Previously s3fs threw away some function return values and returned
EIO instead. This was due to not trusting the mix of -1 and errno
return codes. Correct the obviously incorrect ones via visual
inspection. Stronger typing may find more occurrences. Fixes #1519.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1520 **Author:** [@gaul](https://github.com/gaul) **Created:** 1/16/2021 **Status:** ✅ Merged **Merged:** 1/18/2021 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `errno` --- ### 📝 Commits (1) - [`93b3d0e`](https://github.com/s3fs-fuse/s3fs-fuse/commit/93b3d0e10ee5c16c70fd5f9a96697346b126f4c8) Return more specific errno when available ### 📊 Changes **2 files changed** (+60 additions, -59 deletions) <details> <summary>View changed files</summary> 📝 `src/curl.cpp` (+30 -30) 📝 `src/s3fs.cpp` (+30 -29) </details> ### 📄 Description Previously s3fs threw away some function return values and returned `EIO` instead. This was due to not trusting the mix of -1 and `errno` return codes. Correct the obviously incorrect ones via visual inspection. Stronger typing may find more occurrences. Fixes #1519. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>