[PR #1503] [MERGED] Retry failed may load bad page #2019

New issue

Closed

opened 2026-03-04 02:03:17 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:03:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1503
Author: @fly3366
Created: 12/25/2020
Status: ✅ Merged
Merged: 1/4/2021
Merged by: @ggtakec

Base: master ← Head: master

📝 Commits (1)

dd52671 fix: Add reset offset

📊 Changes

3 files changed (+39 additions, -4 deletions)

View changed files

📝 src/curl.cpp (+8 -1)
📝 src/curl.h (+4 -1)
📝 src/curl_multi.cpp (+27 -2)

📄 Description

Relevant Issue (if applicable)

In MultRead, If Any retry failed. And curl return no OK(such like WRITE ERROR eg.), MultiRead may return 0 and fd may load this page.
But this page is bad. if request include 403、5xx、Partical File(Read Timeout?Connection loss), And next retry is not CURLE_OK, The 403 data may insert into part head and be set loaded(I think we need overwrite it but not loaded).

Details

Another issue?

Multi retry may more large. default is 5(MultiRead) x 5(RequestPerfrom) = 25 count.
If offset and size is 0, may request all file without range.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1503 **Author:** [@fly3366](https://github.com/fly3366) **Created:** 12/25/2020 **Status:** ✅ Merged **Merged:** 1/4/2021 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`dd52671`](https://github.com/s3fs-fuse/s3fs-fuse/commit/dd52671dfb0d161c604de568cb987c4c1932cc72) fix: Add reset offset ### 📊 Changes **3 files changed** (+39 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/curl.cpp` (+8 -1) 📝 `src/curl.h` (+4 -1) 📝 `src/curl_multi.cpp` (+27 -2) </details> ### 📄 Description ### Relevant Issue (if applicable) In MultRead, If Any retry failed. And curl return no OK(such like WRITE ERROR eg.), MultiRead may return 0 and fd may load this page. But this page is bad. if request include 403、5xx、Partical File(Read Timeout?Connection loss), And next retry is not CURLE_OK, The 403 data may insert into part head and be set loaded(I think we need overwrite it but not loaded). ### Details ### Another issue? 1. Multi retry may more large. default is 5(MultiRead) x 5(RequestPerfrom) = 25 count. 2. If offset and size is 0, may request all file without range. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>