mirror of
https://github.com/s3fs-fuse/s3fs-fuse.git
synced 2026-04-25 05:16:00 +03:00
[PR #1498] [MERGED] Fixed about Github Actions failure(centos8 and macos) #2017
Labels
No labels
bug
bug
dataloss
duplicate
enhancement
feature request
help wanted
invalid
need info
performance
pull-request
question
question
testing
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/s3fs-fuse#2017
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1498
Author: @ggtakec
Created: 12/16/2020
Status: ✅ Merged
Merged: 12/23/2020
Merged by: @ggtakec
Base:
master← Head:fix_github_actions📝 Commits (1)
ab31db3Fixed about Github Actions failure(centos8 and macos)📊 Changes
6 files changed (+41 additions, -26 deletions)
View changed files
📝
.github/workflows/ci.yml(+2 -10)📝
.github/workflows/linux-ci-helper.sh(+1 -1)📝
.travis.yml(+1 -1)📝
test/integration-test-common.sh(+14 -3)📝
test/integration-test-main.sh(+9 -9)📝
test/test-utils.sh(+14 -2)📄 Description
Relevant Issue (if applicable)
#1488 #1489
Details
There was an error in macos and centos8 of Github Actions added in #1489.
Also, since last week, there was an error in CentOS8, so I fixed these.
macos
On macos, I found that the test code running s3fs via stdbuf was in a dead loop(blocked)-like state.
The only workaround I could find was to eliminate via stdbuf and start s3fs directly.
However, since the output of s3fs is processed by stdbuf again, I don't think it will be a problem.
If there is a problem, I used this workaround because it only obscures the log.
Also, macos stdbuf/sed/truncate is not compatible with linux, so I changed them to gnu(coreutils etc).
We've already changed truncate/stdbuf, but I've also added sed.
Instead of replacing this programs in ci.yml(for Github Actions), I've moved those to a test script.
centos8
CentOS8 has recently announced CentOS Stream, and it seems that there have been (probably) some changes in line with it.
The
PowerToolsrepository name was changed from uppercase to lowercase(powertools), which caused the test to fail.I fixed this.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.