[PR #1498] [MERGED] Fixed about Github Actions failure(centos8 and macos) #2017

Closed
opened 2026-03-04 02:03:17 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1498
Author: @ggtakec
Created: 12/16/2020
Status: Merged
Merged: 12/23/2020
Merged by: @ggtakec

Base: masterHead: fix_github_actions


📝 Commits (1)

  • ab31db3 Fixed about Github Actions failure(centos8 and macos)

📊 Changes

6 files changed (+41 additions, -26 deletions)

View changed files

📝 .github/workflows/ci.yml (+2 -10)
📝 .github/workflows/linux-ci-helper.sh (+1 -1)
📝 .travis.yml (+1 -1)
📝 test/integration-test-common.sh (+14 -3)
📝 test/integration-test-main.sh (+9 -9)
📝 test/test-utils.sh (+14 -2)

📄 Description

Relevant Issue (if applicable)

#1488 #1489

Details

There was an error in macos and centos8 of Github Actions added in #1489.
Also, since last week, there was an error in CentOS8, so I fixed these.

macos

On macos, I found that the test code running s3fs via stdbuf was in a dead loop(blocked)-like state.
The only workaround I could find was to eliminate via stdbuf and start s3fs directly.
However, since the output of s3fs is processed by stdbuf again, I don't think it will be a problem.
If there is a problem, I used this workaround because it only obscures the log.

Also, macos stdbuf/sed/truncate is not compatible with linux, so I changed them to gnu(coreutils etc).
We've already changed truncate/stdbuf, but I've also added sed.
Instead of replacing this programs in ci.yml(for Github Actions), I've moved those to a test script.

centos8

CentOS8 has recently announced CentOS Stream, and it seems that there have been (probably) some changes in line with it.
The PowerTools repository name was changed from uppercase to lowercase(powertools), which caused the test to fail.
I fixed this.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1498 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 12/16/2020 **Status:** ✅ Merged **Merged:** 12/23/2020 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `fix_github_actions` --- ### 📝 Commits (1) - [`ab31db3`](https://github.com/s3fs-fuse/s3fs-fuse/commit/ab31db3ad250598c4d41144a18cc99b182323227) Fixed about Github Actions failure(centos8 and macos) ### 📊 Changes **6 files changed** (+41 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+2 -10) 📝 `.github/workflows/linux-ci-helper.sh` (+1 -1) 📝 `.travis.yml` (+1 -1) 📝 `test/integration-test-common.sh` (+14 -3) 📝 `test/integration-test-main.sh` (+9 -9) 📝 `test/test-utils.sh` (+14 -2) </details> ### 📄 Description ### Relevant Issue (if applicable) #1488 #1489 ### Details There was an error in macos and centos8 of Github Actions added in #1489. Also, since last week, there was an error in CentOS8, so I fixed these. #### macos On macos, I found that the test code running s3fs via stdbuf was in a dead loop(blocked)-like state. The only workaround I could find was to eliminate via stdbuf and start s3fs directly. However, since the output of s3fs is processed by stdbuf again, I don't think it will be a problem. If there is a problem, I used this workaround because it only obscures the log. Also, macos stdbuf/sed/truncate is not compatible with linux, so I changed them to gnu(coreutils etc). We've already changed truncate/stdbuf, but I've also added sed. Instead of replacing this programs in ci.yml(for Github Actions), I've moved those to a test script. #### centos8 CentOS8 has recently announced CentOS Stream, and it seems that there have been (probably) some changes in line with it. The `PowerTools` repository name was changed from uppercase to lowercase(`powertools`), which caused the test to fail. I fixed this. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-04 02:03:17 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/s3fs-fuse#2017
No description provided.