[PR #1477] [MERGED] Added a condition to the atime test #2003

Closed
opened 2026-03-04 02:03:12 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1477
Author: @ggtakec
Created: 11/18/2020
Status: Merged
Merged: 12/2/2020
Merged by: @ggtakec

Base: masterHead: fix_atime_test


📝 Commits (1)

  • 254d0e0 Added a condition to the atime test

📊 Changes

1 file changed (+44 additions, -20 deletions)

View changed files

📝 test/integration-test-main.sh (+44 -20)

📄 Description

Relevant Issue (if applicable)

#1454

Details

The atime test may fail.
It happens because FUSE does not call the s3fs_utimens entry function.

The cause of this has not been clarified yet, but it seems that it depends on the options and stats when mounting.
It seems to be options such as relatime/noatime.

With the exception of ubuntu:xenial, the test seems to fail if the relatime/noatime option is given.

Therefore, to avoid test failures, bypass the touch -a command test if the relatime/noatime option is set.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1477 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 11/18/2020 **Status:** ✅ Merged **Merged:** 12/2/2020 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `fix_atime_test` --- ### 📝 Commits (1) - [`254d0e0`](https://github.com/s3fs-fuse/s3fs-fuse/commit/254d0e06c1cc052cebeb43c5b78d34d165b01f5d) Added a condition to the atime test ### 📊 Changes **1 file changed** (+44 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `test/integration-test-main.sh` (+44 -20) </details> ### 📄 Description ### Relevant Issue (if applicable) #1454 ### Details The `atime` test may fail. It happens because FUSE does not call the `s3fs_utimens` entry function. The cause of this has not been clarified yet, but it seems that it depends on the options and stats when mounting. It seems to be options such as relatime/noatime. With the exception of ubuntu:xenial, the test seems to fail if the relatime/noatime option is given. Therefore, to avoid test failures, bypass the `touch -a` command test if the relatime/noatime option is set. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-04 02:03:12 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/s3fs-fuse#2003
No description provided.