[PR #1399] [MERGED] Use more descriptive names for digest functions #1960

New issue

Closed

opened 2026-03-04 02:02:59 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:02:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1399
Author: @gaul
Created: 9/15/2020
Status: ✅ Merged
Merged: 9/17/2020
Merged by: @ggtakec

Base: master ← Head: md5-sha256

📝 Commits (1)

b718735 Use more descriptive names for digest functions

📊 Changes

6 files changed (+25 additions, -40 deletions)

View changed files

📝 src/common_auth.cpp (+11 -25)
📝 src/curl.cpp (+3 -3)
📝 src/gnutls_auth.cpp (+4 -4)
📝 src/nss_auth.cpp (+2 -2)
📝 src/openssl_auth.cpp (+2 -2)
📝 src/s3fs_auth.h (+3 -4)

📄 Description

Previously they used hex to refer to binary data which is confusing
since other std::string return types are actually hex. Also remove
unused s3fs_md5sum.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1399 **Author:** [@gaul](https://github.com/gaul) **Created:** 9/15/2020 **Status:** ✅ Merged **Merged:** 9/17/2020 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `md5-sha256` --- ### 📝 Commits (1) - [`b718735`](https://github.com/s3fs-fuse/s3fs-fuse/commit/b7187352e124d7c4fc05c84ae2fe57ca7fcf3f24) Use more descriptive names for digest functions ### 📊 Changes **6 files changed** (+25 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `src/common_auth.cpp` (+11 -25) 📝 `src/curl.cpp` (+3 -3) 📝 `src/gnutls_auth.cpp` (+4 -4) 📝 `src/nss_auth.cpp` (+2 -2) 📝 `src/openssl_auth.cpp` (+2 -2) 📝 `src/s3fs_auth.h` (+3 -4) </details> ### 📄 Description Previously they used hex to refer to binary data which is confusing since other `std::string` return types are actually hex. Also remove unused `s3fs_md5sum`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>