[PR #1394] [MERGED] Added a class for automating fdentity reference counts #1955

New issue

Closed

opened 2026-03-04 02:02:58 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:02:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1394
Author: @ggtakec
Created: 9/13/2020
Status: ✅ Merged
Merged: 9/14/2020
Merged by: @gaul

Base: master ← Head: auto_fdentity

📝 Commits (1)

debe199 Added a class for automating fdentity reference counts

📊 Changes

7 files changed (+373 additions, -162 deletions)

View changed files

📝 src/Makefile.am (+1 -0)
📝 src/fdcache.cpp (+8 -3)
📝 src/fdcache.h (+1 -1)
➕ src/fdcache_auto.cpp (+144 -0)
➕ src/fdcache_auto.h (+63 -0)
📝 src/fdcache_entity.h (+1 -0)
📝 src/s3fs.cpp (+155 -158)

📄 Description

Relevant Issue (if applicable)

#1385 #1387

Details

Due to a bug in the number of references in the file descriptor of a cache file, I have added a class that allows the destructor to automatically decrement the number of references.
By using this class other than fdcache related class, we can prevent the leakage of the number of references.

Checking the number of references by test is difficult.
Therefore, this additional class AutoFdEntity prevents inconsistencies in the number of references.

Also, when the cache file is left open at the end of the s3fs process (when there is a high possibility of a problem), a warning is output.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1394 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 9/13/2020 **Status:** ✅ Merged **Merged:** 9/14/2020 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `auto_fdentity` --- ### 📝 Commits (1) - [`debe199`](https://github.com/s3fs-fuse/s3fs-fuse/commit/debe199c49cb8e5139d58bf5fc45fe5c4d6ad048) Added a class for automating fdentity reference counts ### 📊 Changes **7 files changed** (+373 additions, -162 deletions) <details> <summary>View changed files</summary> 📝 `src/Makefile.am` (+1 -0) 📝 `src/fdcache.cpp` (+8 -3) 📝 `src/fdcache.h` (+1 -1) ➕ `src/fdcache_auto.cpp` (+144 -0) ➕ `src/fdcache_auto.h` (+63 -0) 📝 `src/fdcache_entity.h` (+1 -0) 📝 `src/s3fs.cpp` (+155 -158) </details> ### 📄 Description ### Relevant Issue (if applicable) #1385 #1387 ### Details Due to a bug in the number of references in the file descriptor of a cache file, I have added a class that allows the destructor to automatically decrement the number of references. By using this class other than fdcache related class, we can prevent the leakage of the number of references. Checking the number of references by test is difficult. Therefore, this additional class AutoFdEntity prevents inconsistencies in the number of references. Also, when the cache file is left open at the end of the s3fs process (when there is a high possibility of a problem), a warning is output. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>