[PR #1388] [MERGED] return 0 after parsing "use_session_token" arg #1949

New issue

Closed

opened 2026-03-04 02:02:56 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:02:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1388
Author: @maresb
Created: 9/10/2020
Status: ✅ Merged
Merged: 9/10/2020
Merged by: @gaul

Base: master ← Head: patch-1

📝 Commits (2)

330a3b0 return 0 after parsing "use_session_token" arg
3d27e61 fix whitespace

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 src/s3fs.cpp (+1 -0)

📄 Description

Relevant Issue (if applicable)

#651

Details

I hope this might fix #651.

There's clearly an open bug in #651 confirmed by several users related to the parsing of -o use_session_token. Looking for anomalies in the source code, I noticed that there was a return value everywhere except here, so I suspect this may be (at least partially) responsible.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1388 **Author:** [@maresb](https://github.com/maresb) **Created:** 9/10/2020 **Status:** ✅ Merged **Merged:** 9/10/2020 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (2) - [`330a3b0`](https://github.com/s3fs-fuse/s3fs-fuse/commit/330a3b02f2fe283368b6594dc02a72e75662ea52) return 0 after parsing "use_session_token" arg - [`3d27e61`](https://github.com/s3fs-fuse/s3fs-fuse/commit/3d27e612be32de2dc76f7052f2b5ce45701af9a5) fix whitespace ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/s3fs.cpp` (+1 -0) </details> ### 📄 Description ### Relevant Issue (if applicable) #651 ### Details I hope this might fix #651. There's clearly an open bug in #651 confirmed by several users related to the parsing of `-o use_session_token`. Looking for anomalies in the source code, I noticed that there was a return value everywhere except here, so I suspect this may be (at least partially) responsible. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>