[PR #1365] [MERGED] Dynamically determine whether lseek extended options are supported #1939

New issue

Closed

opened 2026-03-04 02:02:53 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:02:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1365
Author: @ggtakec
Created: 8/16/2020
Status: ✅ Merged
Merged: 8/20/2020
Merged by: @ggtakec

Base: master ← Head: check_lseek

📝 Commits (1)

55cb892 Dynamically determine whether lseek extended options are supported

📊 Changes

3 files changed (+65 additions, -0 deletions)

View changed files

📝 src/fdcache.cpp (+57 -0)
📝 src/fdcache.h (+3 -0)
📝 src/sighandlers.cpp (+5 -0)

📄 Description

Relevant Issue (if applicable)

#1354

Details

This PR is a code to avoid that s3fs cannot be built when whence SEEK_HOLE/SEEK_DATA of the lseek function is undefined.
Also, in the runtime environment where lseek cannot recognize these whence, s3fs will not start up with an error if the set_check_cache_sigusr1 option is specified.

This fix will broaden the build and run environments.

However, I think that we do not want to change the target OS supported by s3fs by this fix does.
The environment that can be built/executed is increase to wide, but the OS environment that can be officially supported follows the contents discussed in #1354.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1365 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 8/16/2020 **Status:** ✅ Merged **Merged:** 8/20/2020 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `check_lseek` --- ### 📝 Commits (1) - [`55cb892`](https://github.com/s3fs-fuse/s3fs-fuse/commit/55cb8920d540139523b30d3781b64dca9bf1e4cd) Dynamically determine whether lseek extended options are supported ### 📊 Changes **3 files changed** (+65 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/fdcache.cpp` (+57 -0) 📝 `src/fdcache.h` (+3 -0) 📝 `src/sighandlers.cpp` (+5 -0) </details> ### 📄 Description ### Relevant Issue (if applicable) #1354 ### Details This PR is a code to avoid that s3fs cannot be built when whence SEEK_HOLE/SEEK_DATA of the lseek function is undefined. Also, in the runtime environment where lseek cannot recognize these whence, s3fs will not start up with an error if the set_check_cache_sigusr1 option is specified. This fix will broaden the build and run environments. However, I think that we do not want to change the target OS supported by s3fs by this fix does. The environment that can be built/executed is increase to wide, but the OS environment that can be officially supported follows the contents discussed in #1354. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>