[PR #1349] [MERGED] Fixed a bug about move file over limit of ensure space #1933

New issue

Closed

opened 2026-03-04 02:02:52 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:02:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1349
Author: @ggtakec
Created: 8/2/2020
Status: ✅ Merged
Merged: 8/16/2020
Merged by: @gaul

Base: master ← Head: fix_ensure_mv

📝 Commits (1)

7e3f939 Fixed a bug about move file over limit of ensure space

📊 Changes

6 files changed (+350 additions, -82 deletions)

View changed files

📝 src/fdcache.cpp (+108 -3)
📝 src/fdcache.h (+8 -2)
📝 src/s3fs.cpp (+198 -57)
📝 src/s3fs_util.cpp (+24 -9)
📝 src/s3fs_util.h (+9 -8)
📝 test/integration-test-main.sh (+3 -3)

📄 Description

Relevant Issue (if applicable)

#1345

Details

There is a case where the header(meta) information is put during multipart upload, and the file size becomes 0.
Thus, this PR code is that s3fs updates header(meta) information after multipart upload is completed.

About bug

This bug happens when s3fs move a file from another disk(not managed by s3fs) when there is not enough free disk space.
(It seems to be the same with a copy, but it has not been confirmed)
In such a case, we need to PUT each header information etc. after the file upload is completed.

About test case

In addition, I considered a test case for confirming this fix, but it was not decided upon completion.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1349 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 8/2/2020 **Status:** ✅ Merged **Merged:** 8/16/2020 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `fix_ensure_mv` --- ### 📝 Commits (1) - [`7e3f939`](https://github.com/s3fs-fuse/s3fs-fuse/commit/7e3f93971bf117055becd9efda1ee77e2249e3e5) Fixed a bug about move file over limit of ensure space ### 📊 Changes **6 files changed** (+350 additions, -82 deletions) <details> <summary>View changed files</summary> 📝 `src/fdcache.cpp` (+108 -3) 📝 `src/fdcache.h` (+8 -2) 📝 `src/s3fs.cpp` (+198 -57) 📝 `src/s3fs_util.cpp` (+24 -9) 📝 `src/s3fs_util.h` (+9 -8) 📝 `test/integration-test-main.sh` (+3 -3) </details> ### 📄 Description ### Relevant Issue (if applicable) #1345 ### Details There is a case where the header(meta) information is put during multipart upload, and the file size becomes 0. Thus, this PR code is that s3fs updates header(meta) information after multipart upload is completed. #### About bug This bug happens when s3fs move a file from another disk(not managed by s3fs) when there is not enough free disk space. (It seems to be the same with a copy, but it has not been confirmed) In such a case, we need to PUT each header information etc. after the file upload is completed. #### About test case In addition, I considered a test case for confirming this fix, but it was not decided upon completion. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>