[PR #1343] [MERGED] Moved the SIGUSR2 handler to S3fsSignals class #1929

New issue

Closed

opened 2026-03-04 02:02:50 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:02:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1343
Author: @ggtakec
Created: 7/26/2020
Status: ✅ Merged
Merged: 7/28/2020
Merged by: @gaul

Base: master ← Head: move_sigusr2

📝 Commits (1)

ece7988 Moved the SIGUSR2 handler to S3fsSignals class

📊 Changes

3 files changed (+70 additions, -66 deletions)

View changed files

📝 src/s3fs.cpp (+8 -66)
📝 src/sighandlers.cpp (+56 -0)
📝 src/sighandlers.h (+6 -0)

📄 Description

Relevant Issue (if applicable)

#1334

Details

Since a class summarizing the processing of the signal handlers has been added, the SIGUSR2 handler and its related processing have been moved to that class.
SIGUSR2 handler is set to bump up the debug log level.
Also, the debugging log level is set by a global variable(it is using a global variable because it is called from a macro in anywhere), but I also moved the operation function of this variable to that class.
Please note that the processing logic has not changed.

This will be a underplot as we will combine other signal handlers into S3fsSignals in the future.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1343 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 7/26/2020 **Status:** ✅ Merged **Merged:** 7/28/2020 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `move_sigusr2` --- ### 📝 Commits (1) - [`ece7988`](https://github.com/s3fs-fuse/s3fs-fuse/commit/ece798808bc7af74137a72d22f8a60963044563a) Moved the SIGUSR2 handler to S3fsSignals class ### 📊 Changes **3 files changed** (+70 additions, -66 deletions) <details> <summary>View changed files</summary> 📝 `src/s3fs.cpp` (+8 -66) 📝 `src/sighandlers.cpp` (+56 -0) 📝 `src/sighandlers.h` (+6 -0) </details> ### 📄 Description ### Relevant Issue (if applicable) #1334 ### Details Since a class summarizing the processing of the signal handlers has been added, the SIGUSR2 handler and its related processing have been moved to that class. SIGUSR2 handler is set to bump up the debug log level. Also, the debugging log level is set by a global variable(it is using a global variable because it is called from a macro in anywhere), but I also moved the operation function of this variable to that class. Please note that the processing logic has not changed. This will be a underplot as we will combine other signal handlers into S3fsSignals in the future. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>