[PR #1319] [MERGED] Fixed upload error about mixuploading sparse file and truncating file #1916

New issue

Closed

opened 2026-03-04 02:02:47 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:02:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1319
Author: @ggtakec
Created: 6/27/2020
Status: ✅ Merged
Merged: 6/27/2020
Merged by: @gaul

Base: master ← Head: fix_mixupload

📝 Commits (1)

32238b1 Fixed upload error about mixuploading sparse file and truncating file

📊 Changes

3 files changed (+101 additions, -26 deletions)

View changed files

📝 src/fdcache.cpp (+23 -7)
📝 src/s3fs.cpp (+10 -2)
📝 test/integration-test-main.sh (+68 -17)

📄 Description

Relevant Issue (if applicable)

#1311 #1318

Details

There were cases where an error occurred when uploading a mix of files.
It occurs when the file is directly created by truncate(size larger than one entity size(5MB or more) of multipart upload).
In addition to truncate, it could also occur if the existing file size was changed significantly.

These bug has been fixed by this PR.
The fix is to set the modify flag to ON in the stretched area when performing an open(internal processing) that specifies the file size.
This bug is due to a missing fix when supporting the mix upload process.

And I also added test cases(I also changed some existing code comments).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1319 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 6/27/2020 **Status:** ✅ Merged **Merged:** 6/27/2020 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `fix_mixupload` --- ### 📝 Commits (1) - [`32238b1`](https://github.com/s3fs-fuse/s3fs-fuse/commit/32238b10b7cebcaadc42a48341ad63d1781743bc) Fixed upload error about mixuploading sparse file and truncating file ### 📊 Changes **3 files changed** (+101 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `src/fdcache.cpp` (+23 -7) 📝 `src/s3fs.cpp` (+10 -2) 📝 `test/integration-test-main.sh` (+68 -17) </details> ### 📄 Description ### Relevant Issue (if applicable) #1311 #1318 ### Details There were cases where an error occurred when uploading a mix of files. It occurs when the file is directly created by truncate(size larger than one entity size(5MB or more) of multipart upload). In addition to truncate, it could also occur if the existing file size was changed significantly. These bug has been fixed by this PR. The fix is to set the modify flag to ON in the stretched area when performing an open(internal processing) that specifies the file size. This bug is due to a missing fix when supporting the mix upload process. And I also added test cases(I also changed some existing code comments). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>