[PR #1303] [MERGED] Relink cache stats file atomically via rename #1911

New issue

Closed

opened 2026-03-04 02:02:45 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:02:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1303
Author: @gaul
Created: 5/31/2020
Status: ✅ Merged
Merged: 5/31/2020
Merged by: @ggtakec

Base: master ← Head: rename/use_cache

📝 Commits (1)

2743215 Relink cache stats file atomically via rename

📊 Changes

1 file changed (+3 additions, -7 deletions)

View changed files

📝 src/fdcache.cpp (+3 -7)

📄 Description

The new file may already exist so link may fail. Further link/unlink
is not atomic. Addresses an error when renaming an open with with
use_cache. References #1296.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1303 **Author:** [@gaul](https://github.com/gaul) **Created:** 5/31/2020 **Status:** ✅ Merged **Merged:** 5/31/2020 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `rename/use_cache` --- ### 📝 Commits (1) - [`2743215`](https://github.com/s3fs-fuse/s3fs-fuse/commit/274321524c395f583633989d040dd98ed4aa11ed) Relink cache stats file atomically via rename ### 📊 Changes **1 file changed** (+3 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/fdcache.cpp` (+3 -7) </details> ### 📄 Description The new file may already exist so link may fail. Further `link`/`unlink` is not atomic. Addresses an error when renaming an open with with `use_cache`. References #1296. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>