[PR #1285] [MERGED] Not abort process by exception threw from s3fs_strtoofft #1901

New issue

Closed

opened 2026-03-04 02:02:43 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:02:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1285
Author: @ggtakec
Created: 5/3/2020
Status: ✅ Merged
Merged: 5/22/2020
Merged by: @ggtakec

Base: master ← Head: wrapped_s3fs_strtoofft

📝 Commits (2)

97c249d Not abort process by exception threw from s3fs_strtoofft
80c11b6 Not abort process by exception threw from s3fs_strtoofft

📊 Changes

7 files changed (+91 additions, -59 deletions)

View changed files

📝 src/curl.cpp (+15 -3)
📝 src/fdcache.cpp (+7 -34)
📝 src/s3fs.cpp (+17 -17)
📝 src/s3fs_util.cpp (+5 -5)
📝 src/string_util.cpp (+35 -0)
📝 src/string_util.h (+2 -0)
📝 src/test_string_util.cpp (+10 -0)

📄 Description

Relevant Issue (if applicable)

#1256 #1191

Details

Although the s3fs_strtoofft() function throws an exception, the process may abort because s3fs does not catch this exception.(ex. #1256 #1191 )
I prepared a wrap function that catches the exception and returns the result or the value(=default value 0).
The part that called each s3fs_strtoofft function is replaced with these wrap functions.
The s3fs-fuse option analysis function may be left as it is. But it has been modified according to this change.

This fix also helps prevent unexpected aborts in exceptions, but rather to ease debugging difficulties when aborted.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1285 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 5/3/2020 **Status:** ✅ Merged **Merged:** 5/22/2020 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `wrapped_s3fs_strtoofft` --- ### 📝 Commits (2) - [`97c249d`](https://github.com/s3fs-fuse/s3fs-fuse/commit/97c249d5b922989e5a191346ab40737baaecd5de) Not abort process by exception threw from s3fs_strtoofft - [`80c11b6`](https://github.com/s3fs-fuse/s3fs-fuse/commit/80c11b6c127b5bf0670c48df49f9f5b858112ac7) Not abort process by exception threw from s3fs_strtoofft ### 📊 Changes **7 files changed** (+91 additions, -59 deletions) <details> <summary>View changed files</summary> 📝 `src/curl.cpp` (+15 -3) 📝 `src/fdcache.cpp` (+7 -34) 📝 `src/s3fs.cpp` (+17 -17) 📝 `src/s3fs_util.cpp` (+5 -5) 📝 `src/string_util.cpp` (+35 -0) 📝 `src/string_util.h` (+2 -0) 📝 `src/test_string_util.cpp` (+10 -0) </details> ### 📄 Description ### Relevant Issue (if applicable) #1256 #1191 ### Details Although the s3fs_strtoofft() function throws an exception, the process may abort because s3fs does not catch this exception.(ex. #1256 #1191 ) I prepared a wrap function that catches the exception and returns the result or the value(=default value 0). The part that called each s3fs_strtoofft function is replaced with these wrap functions. _The s3fs-fuse option analysis function may be left as it is. But it has been modified according to this change._ This fix also helps prevent unexpected aborts in exceptions, but rather to ease debugging difficulties when aborted. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>